Mixed Content: Move subframe checks into ResourceFetcher.

Mixed Content: Move subframe checks into ResourceFetcher.

Currently we're checking for mixed content when loading the main
resource of subframes in two places: DocumentLoader and ResourceFetcher.
The former properly checks against the frame's parent frame, while the
latter bypasses the checks entirely by virtue of the request's
'Resource::Type' being 'Main'.

This is both confusing and difficult to replicate when moving to the
brave new world of request contexts and frame types that Fetch now
defines.

This patch drops the DocumentLoader check, and moves the relevant
logic into ResourceFetcher::canRequest and
ResourceFetcher::checkInsecureContent.

BUG=400087
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181383

[Mike West, 2014-09-04 10:42:34]

Patchset #1 (id:1) has been deleted

[Mike West, 2014-09-04 10:44:12]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2014-09-04 10:44:12]

Jochen, would you mind taking a look at this patch? It should have no
web-visible effect, as it just moves a check from one part of the code to
another. Let's see if the bots agree! 

Running chromium-side bots as well, as they have a tendency to break with mixed
content changes. :(

[jochen (gone - plz use gerrit), 2014-09-04 11:06:23]

lgtm

https://codereview.chromium.org/544573002/diff/20001/Source/core/fetch/Resour...
File Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/544573002/diff/20001/Source/core/fetch/Resour...
Source/core/fetch/ResourceFetcher.cpp:628: //    printf("Evaluating %s in %s\n-
Type: %d\n- Context: %d\n- Frame Type: %d\n\n",
remove?

[Mike West, 2014-09-04 11:07:35]

https://codereview.chromium.org/544573002/diff/20001/Source/core/fetch/Resour...
File Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/544573002/diff/20001/Source/core/fetch/Resour...
Source/core/fetch/ResourceFetcher.cpp:628: //    printf("Evaluating %s in %s\n-
Type: %d\n- Context: %d\n- Frame Type: %d\n\n",
On 2014/09/04 11:06:23, jochen wrote:
> remove?

Ah. Ha. *cough* Yes. :)

[Mike West, 2014-09-04 12:19:08]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-09-04 12:19:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mkwst@chromium.org/544573002/40001

[Mike West, 2014-09-04 16:03:27]

The CQ bit was unchecked by mkwst@chromium.org

[Mike West, 2014-09-04 16:03:57]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-09-04 16:05:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mkwst@chromium.org/544573002/40001

[commit-bot: I haz the power, 2014-09-04 17:20:55]

Committed patchset #2 (id:40001) as 181383

[jochen (gone - plz use gerrit), 2014-09-08 08:31:40]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/550083003/ by jochen@chromium.org.

The reason for reverting is: calls V8 from a non-V8 context.