Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: Source/core/css/html.css

Issue 544473002: Line-height style shouldn't apply to option elements (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/forms/select/listbox-line-height-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/html.css
diff --git a/Source/core/css/html.css b/Source/core/css/html.css
index 17f7402738542e4f9886cbb4704e53b461c51cd7..4281ff49a7c8172b50bc1635a415be7925313fe5 100644
--- a/Source/core/css/html.css
+++ b/Source/core/css/html.css
@@ -786,6 +786,11 @@ option {
min-height: 1.2em;
}
+select:-internal-list-box option,
+select:-internal-list-box optgroup {
+ line-height: initial !important;
tkent 2014/09/05 02:29:17 Do we need !important? It prevents web authors fro
keishi 2014/09/05 04:56:34 I added it because I confirmed Firefox and IE don'
tkent 2014/09/05 05:01:14 Yeah, styling line-height of OPTION is an improvem
+}
+
select:-internal-list-box:focus option:checked {
background-color: -internal-active-list-box-selection !important;
color: -internal-active-list-box-selection-text !important;
« no previous file with comments | « LayoutTests/fast/forms/select/listbox-line-height-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698