Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: Source/core/css/html.css

Issue 544473002: Line-height style shouldn't apply to option elements (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/fast/forms/select/listbox-line-height-expected.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * The default style sheet used to render HTML. 2 * The default style sheet used to render HTML.
3 * 3 *
4 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 4 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 768 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 } 779 }
780 780
781 option { 781 option {
782 font-weight: normal; 782 font-weight: normal;
783 display: block; 783 display: block;
784 padding: 0 2px 1px 2px; 784 padding: 0 2px 1px 2px;
785 white-space: pre; 785 white-space: pre;
786 min-height: 1.2em; 786 min-height: 1.2em;
787 } 787 }
788 788
789 select:-internal-list-box option,
790 select:-internal-list-box optgroup {
791 line-height: initial !important;
tkent 2014/09/05 02:29:17 Do we need !important? It prevents web authors fro
keishi 2014/09/05 04:56:34 I added it because I confirmed Firefox and IE don'
tkent 2014/09/05 05:01:14 Yeah, styling line-height of OPTION is an improvem
792 }
793
789 select:-internal-list-box:focus option:checked { 794 select:-internal-list-box:focus option:checked {
790 background-color: -internal-active-list-box-selection !important; 795 background-color: -internal-active-list-box-selection !important;
791 color: -internal-active-list-box-selection-text !important; 796 color: -internal-active-list-box-selection-text !important;
792 } 797 }
793 798
794 select:-internal-list-box option:checked { 799 select:-internal-list-box option:checked {
795 background-color: -internal-inactive-list-box-selection !important; 800 background-color: -internal-inactive-list-box-selection !important;
796 color: -internal-inactive-list-box-selection-text !important; 801 color: -internal-inactive-list-box-selection-text !important;
797 } 802 }
798 803
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
1062 @page { 1067 @page {
1063 /* FIXME: Define the right default values for page properties. */ 1068 /* FIXME: Define the right default values for page properties. */
1064 size: auto; 1069 size: auto;
1065 margin: auto; 1070 margin: auto;
1066 padding: 0px; 1071 padding: 0px;
1067 border-width: 0px; 1072 border-width: 0px;
1068 } 1073 }
1069 1074
1070 /* noscript is handled internally, as it depends on settings. */ 1075 /* noscript is handled internally, as it depends on settings. */
1071 1076
OLDNEW
« no previous file with comments | « LayoutTests/fast/forms/select/listbox-line-height-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698