Line-height style shouldn't apply to option elements

Line-height style shouldn't apply to option elements

BUG=410316
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182386

[keishi, 2014-09-04 03:48:43]

Firefox and IE ignore line-height style for option elements.

[keishi, 2014-09-04 03:48:51]

keishi@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2014-09-05 02:29:17]

https://codereview.chromium.org/544473002/diff/1/Source/core/css/html.css
File Source/core/css/html.css (right):

https://codereview.chromium.org/544473002/diff/1/Source/core/css/html.css#new...
Source/core/css/html.css:791: line-height: initial !important;
Do we need !important?
It prevents web authors from changing line-height.

[keishi, 2014-09-05 04:56:34]

https://codereview.chromium.org/544473002/diff/1/Source/core/css/html.css
File Source/core/css/html.css (right):

https://codereview.chromium.org/544473002/diff/1/Source/core/css/html.css#new...
Source/core/css/html.css:791: line-height: initial !important;
On 2014/09/05 02:29:17, tkent wrote:
> Do we need !important?
> It prevents web authors from changing line-height.

I added it because I confirmed Firefox and IE don't allow changing line-height
at all.
I'll remove it because the issue with Bootstrap should be fixed and I imagine
people wanting to set line-heights if they realize they can style option
elements.

[tkent, 2014-09-05 05:01:14]

lgtm

https://codereview.chromium.org/544473002/diff/1/Source/core/css/html.css
File Source/core/css/html.css (right):

https://codereview.chromium.org/544473002/diff/1/Source/core/css/html.css#new...
Source/core/css/html.css:791: line-height: initial !important;
On 2014/09/05 04:56:34, keishi wrote:
> On 2014/09/05 02:29:17, tkent wrote:
> > Do we need !important?
> > It prevents web authors from changing line-height.
> 
> I added it because I confirmed Firefox and IE don't allow changing line-height
> at all.
> I'll remove it because the issue with Bootstrap should be fixed and I imagine
> people wanting to set line-heights if they realize they can style option
> elements.

Yeah, styling line-height of OPTION is an improvement even though IE and Firefox
don't allow it.
If we have other compatibility issue reports, let's reconsider.

[keishi, 2014-09-05 05:11:06]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-09-05 05:12:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/keishi@chromium.org/544473002/20001

[commit-bot: I haz the power, 2014-09-05 07:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 07:03:56]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/25692)

[tkent, 2014-09-17 05:13:49]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-09-17 05:14:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/544473002/20001

[commit-bot: I haz the power, 2014-09-17 06:41:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-17 06:41:59]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/25692)

[keishi, 2014-09-22 04:14:50]

User agent style sheet rules are weaker than I thought.
When user agent style sheet has a rule for "A B" and author style sheet has a
rule for "A", the author style sheet seems to win.

I think I need to add back the !important to solve this.

[tkent, 2014-09-22 04:15:37]

On 2014/09/22 04:14:50, keishi wrote:
> User agent style sheet rules are weaker than I thought.
> When user agent style sheet has a rule for "A B" and author style sheet has a
> rule for "A", the author style sheet seems to win.
> 
> I think I need to add back the !important to solve this.

ok, please go ahead.

[keishi, 2014-09-22 04:41:59]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-09-22 04:42:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/544473002/60001

[commit-bot: I haz the power, 2014-09-22 05:49:40]

Committed patchset #4 (id:60001) as 182386