Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

Issue 544463002: Integration test for data reduction proxy version header (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from bolian Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
index fd92a4dfabc213aef111c058c9593b719367b5db..e04e3fb6b723547c7e222145ff89ebcec577d4b8 100644
--- a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
@@ -214,6 +214,26 @@ class ChromeProxyHTTPFallbackViaHeader(ChromeProxyValidation):
self._metrics.AddResultsForHTTPFallback(tab, results, proxies, bad_proxies)
+class ChromeProxyClientVersion(ChromeProxyValidation):
+ """Correctness measurement for version directives in Chrome-Proxy header.
+
+ The test verifies that the version information provided in the Chrome-Proxy
+ request header overrides any version, if specified, that is provided in the
+ user agent string.
+ """
+
+ def __init__(self):
+ super(ChromeProxyClientVersion, self).__init__()
+
+ def CustomizeBrowserOptions(self, options):
+ super(ChromeProxyClientVersion,
+ self).CustomizeBrowserOptions(options)
+ options.AppendExtraBrowserArgs('--user-agent="Chrome/32.0.1700.99"')
+
+ def AddResults(self, tab, results):
+ self._metrics.AddResultsForClientVersion(tab, results)
+
+
class ChromeProxySmoke(ChromeProxyValidation):
"""Smoke measurement for basic chrome proxy correctness."""

Powered by Google App Engine
This is Rietveld 408576698