Chromium Code Reviews| Index: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py |
| diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py |
| index fd92a4dfabc213aef111c058c9593b719367b5db..d573b2c0247f233b23fe0c3081c97697cf68553f 100644 |
| --- a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py |
| +++ b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py |
| @@ -214,6 +214,28 @@ class ChromeProxyHTTPFallbackViaHeader(ChromeProxyValidation): |
| self._metrics.AddResultsForHTTPFallback(tab, results, proxies, bad_proxies) |
| + # Depends on the fix of http://crbug.com/330342. |
|
bolian
2014/09/04 02:09:02
wrong comment?
bengr
2014/09/04 18:42:23
Done.
|
| +class ChromeProxyVersionTest(ChromeProxyValidation): |
| + """Correctness measurement for version directives in Chrome-Proxy header. |
| + |
| + In this test, the configured proxy is the chromeproxy-test server. The test |
|
bolian
2014/09/04 02:09:02
rm the first sentence.
bengr
2014/09/04 18:42:23
Done.
|
| + verifies that the version information provided in the Chrome-Proxy request |
| + header overrides any version, if specified, that is provided in the user |
| + agent string. |
| + """ |
| + |
| + def __init__(self): |
| + super(ChromeProxyVersionTest, self).__init__() |
| + |
| + def CustomizeBrowserOptions(self, options): |
| + super(ChromeProxyVersionTest, |
| + self).CustomizeBrowserOptions(options) |
| + options.AppendExtraBrowserArgs('--user-agent="No Version"') |
|
bolian
2014/09/04 02:09:02
This is not the final UA string, right? You want
bengr
2014/09/04 18:42:23
Done.
|
| + |
| + def AddResults(self, tab, results): |
| + self._metrics.AddResultsForVersionTest(tab, results) |
| + |
| + |
| class ChromeProxySmoke(ChromeProxyValidation): |
| """Smoke measurement for basic chrome proxy correctness.""" |