Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Issue 544453004: Add ability to run async magnitude-perf tests. (Closed)

Created:
6 years, 3 months ago by eustas
Modified:
6 years, 3 months ago
Reviewers:
eseidel
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add ability to run async magnitude-perf tests. I would like to add new time complexity test. Unfortunately, current framework doesn't support async tests. In this patch I wrap for and while operators, so they could run asynchronously. CL I'm going to write test to (fix n^2 HTML parsing): https://codereview.chromium.org/494993002/ Here is the first async test: https://codereview.chromium.org/500363002/ BUG=410790 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181539

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -18 lines) Patch
M LayoutTests/resources/magnitude-perf.js View 1 2 5 chunks +106 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
eustas
6 years, 3 months ago (2014-09-04 11:44:24 UTC) #2
Nils Barth (inactive)
Hi Eustas, Could you give some context for this? (Code looks fine from quick look.) ...
6 years, 3 months ago (2014-09-04 13:51:41 UTC) #3
eustas
On 2014/09/04 13:51:41, Nils Barth (inactive) wrote: > Hi Eustas, > Could you give some ...
6 years, 3 months ago (2014-09-04 14:39:31 UTC) #4
Nils Barth (inactive)
On 2014/09/04 14:39:31, eustas wrote: > On 2014/09/04 13:51:41, Nils Barth (inactive) wrote: > > ...
6 years, 3 months ago (2014-09-04 14:48:42 UTC) #5
eseidel
lgtm
6 years, 3 months ago (2014-09-05 17:02:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/544453004/40001
6 years, 3 months ago (2014-09-05 17:02:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/9660)
6 years, 3 months ago (2014-09-05 17:14:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/544453004/40001
6 years, 3 months ago (2014-09-08 05:41:00 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 06:05:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 181539

Powered by Google App Engine
This is Rietveld 408576698