Source/core/frame/Frame.cpp - Issue 544443002: Detach all subframes before swapping a frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/Frame.cpp

Issue 544443002: Detach all subframes before swapping a frame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixes based on Ken's review and Daniel's comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/Frame.cpp

diff --git a/Source/core/frame/Frame.cpp b/Source/core/frame/Frame.cpp

index f647b3e5988b5ed202236a17a12183a39112612d..a0eaf7aa43b385ec6bbf8234a456f07c91e560df 100644

--- a/Source/core/frame/Frame.cpp

+++ b/Source/core/frame/Frame.cpp

@@ -93,6 +93,7 @@ Frame::~Frame()

void Frame::detachChildren()

{

+ ASSERT(refCount() > 1);

kenrb 2014/09/05 19:28:09 I'm fine with this, but it should have a comment o

nasko 2014/09/05 23:37:29 Done.

typedef Vector<RefPtr<Frame> > FrameVector;

FrameVector childrenToDetach;

childrenToDetach.reserveCapacity(tree().childCount());

« no previous file with comments | « no previous file | Source/web/WebFrame.cpp » ('j') | no next file with comments »