Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(19)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: Source/web/tests/data/subframe-b.html
Issue
544443002
:
Detach all subframes before swapping a frame. (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove ASSERT in detachChildren, since FrameLoader::commitProvisionalLoad can hit it with ref count…
Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
Source/web/WebFrame.cpp
Source/web/tests/WebFrameTest.cpp
Source/web/tests/data/subframe-b.html
public/web/WebFrame.h
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« Source/web/WebFrame.cpp
('K') |
« Source/web/tests/WebFrameTest.cpp
('k') |
public/web/WebFrame.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 <!DOCTYPE html>
1 <!DOCTYPE html>
2 <html>
2 <html>
3 <body>
3 <body>
4 <p>b
4 <p>b
5
<iframe name="foo" src="subframe-a.html">
5 </body>
6 </body>
6 </html>
7 </html>
OLD
NEW
« Source/web/WebFrame.cpp
('K') |
« Source/web/tests/WebFrameTest.cpp
('k') |
public/web/WebFrame.h »
('j') |
no next file with comments »
Issue 544443002: Detach all subframes before swapping a frame. (Closed)
Created 6 years, 3 months ago by nasko
Modified 6 years, 3 months ago
Reviewers: dcheng, kenrb, eseidel
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 6
This is Rietveld
408576698