Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/common/BUILD.gn

Issue 544423002: Convert GN visibility variables to lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/chrome_repack_locales.gni ('k') | components/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//tools/grit/grit_rule.gni") 5 import("//tools/grit/grit_rule.gni")
6 6
7 gypi_values = exec_script( 7 gypi_values = exec_script(
8 "//build/gypi_to_gn.py", 8 "//build/gypi_to_gn.py",
9 [ rebase_path("../chrome_common.gypi") ], 9 [ rebase_path("../chrome_common.gypi") ],
10 "scope", 10 "scope",
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 if (safe_browsing_mode == 2) { 237 if (safe_browsing_mode == 2) {
238 defines += [ "MOBILE_SAFE_BROWSING" ] 238 defines += [ "MOBILE_SAFE_BROWSING" ]
239 } 239 }
240 } 240 }
241 241
242 if (is_linux) { 242 if (is_linux) {
243 # TODO(brettw) this duplicates "//chrome/common:version" which applies to 243 # TODO(brettw) this duplicates "//chrome/common:version" which applies to
244 # Windows. 244 # Windows.
245 import("//chrome/version.gni") 245 import("//chrome/version.gni")
246 process_version("version") { 246 process_version("version") {
247 visibility = ":common" 247 visibility = [ ":common" ]
248 source = "chrome_version_info_posix.h.version" 248 source = "chrome_version_info_posix.h.version"
249 output = "$target_gen_dir/chrome_version_info_posix.h" 249 output = "$target_gen_dir/chrome_version_info_posix.h"
250 } 250 }
251 } else { 251 } else {
252 # Other platforms have a different way to do versioning. 252 # Other platforms have a different way to do versioning.
253 group("version") { 253 group("version") {
254 } 254 }
255 } 255 }
256 256
257 # GN version: chrome/common_constants.gyp:common_constants 257 # GN version: chrome/common_constants.gyp:common_constants
(...skipping 30 matching lines...) Expand all
288 "//components/bookmarks/common", 288 "//components/bookmarks/common",
289 "//third_party/widevine/cdm:version_h", 289 "//third_party/widevine/cdm:version_h",
290 ] 290 ]
291 291
292 if (enable_nacl) { 292 if (enable_nacl) {
293 deps += [ 293 deps += [
294 #'../components/nacl.gyp:nacl_switches', TODO(GYP) 294 #'../components/nacl.gyp:nacl_switches', TODO(GYP)
295 ] 295 ]
296 } 296 }
297 } 297 }
OLDNEW
« no previous file with comments | « chrome/chrome_repack_locales.gni ('k') | components/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698