Issue 544413002: Patch on top of https://codereview.chromium.org/474593002

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 544413002: Patch on top of https://codereview.chromium.org/474593002 (Closed)

Created:
6 years, 3 months ago by jsbell

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@sw-gavin

Project:
chromium

Visibility:
Public.

More Reviews

Description

Patch on top of https://codereview.chromium.org/474593002 Addresses ServiceWorkerCacheStorageDispatcher vs. WebCache lifetime issue noted in https://codereview.chromium.org/433793002/ caused by lazy finalization of WebCache objects c/o Oilpan. DO NOT LAND

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -3 lines)			Patch
	M	content/renderer/service_worker/service_worker_cache_storage_dispatcher.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc	View		3 chunks	+24 lines, -2 lines	0 comments	Download