Fix Auth browser-test failure: make sure element is ready to receive click.

chrome/test/remoting/remote_desktop_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/remoting/remote_desktop_browsertest.h"
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/json/json_reader.h"
 #include "base/path_service.h"
@@ skipping 291 matching lines @@
     // active_web_contents() is still the login window but the observer
     // should be set up to observe the chromoting window because that is
     // where we'll receive the message from the login window and reload the
     // chromoting app.
     content::WindowedNotificationObserver observer(
         content::NOTIFICATION_LOAD_STOP,
           base::Bind(
               &RemoteDesktopBrowserTest::IsAuthenticatedInWindow,
               browser()->tab_strip_model()->GetActiveWebContents()));
 
-    ExecuteScript(
-        "lso.approveButtonAction();"
-        "document.forms[\"connect-approve\"].submit();");
+    while (!IsEnabled("submit_approve_access")) {

[weitao, 2014/09/08 23:07:48]

You should use a ConditionalWaiter for this. And we should move this to
ClickOnControl so that we don't run into similar issues again.

[anandc1, 2014/09/09 00:59:16]

Done.

+      ASSERT_TRUE(TimeoutWaiter(base::TimeDelta::FromSeconds(1)).Wait());
+    }
+
+    ClickOnControl("submit_approve_access");
 
     observer.Wait();
 
     // Popping the login window off the stack to return to the chromoting
     // window.
     web_contents_stack_.pop_back();
   }
 
   ASSERT_TRUE(GetCurrentURL() == Chromoting_Main_URL());
 
@@ skipping 470 matching lines @@
 // static
 bool RemoteDesktopBrowserTest::IsHostActionComplete(
     content::WebContents* client_web_content,
     std::string host_action_var) {
   return ExecuteScriptAndExtractBool(
       client_web_content,
       host_action_var);
 }
 
 }  // namespace remoting