Fixing problem that after a browser crash in multi user mode, an incorrect user might show up.

chrome/browser/profiles/profile_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/path_service.h"
@@ skipping 184 matching lines @@
 }
 
 TEST_F(ProfileManagerTest, DefaultProfileDir) {
   base::FilePath expected_default =
       base::FilePath().AppendASCII(chrome::kInitialProfile);
   EXPECT_EQ(
       expected_default.value(),
       g_browser_process->profile_manager()->GetInitialProfileDir().value());
 }
 
+MATCHER(NotFail, "Profile creation failure status is not reported.") {
+  return arg == Profile::CREATE_STATUS_CREATED ||
+         arg == Profile::CREATE_STATUS_INITIALIZED;
+}
+
+MATCHER(SameNotNull, "The same non-NULL value for all calls.") {
+  if (!g_created_profile)
+    g_created_profile = arg;
+  return arg != NULL && arg == g_created_profile;
+}
+
 #if defined(OS_CHROMEOS)
 
 // This functionality only exists on Chrome OS.
 TEST_F(ProfileManagerTest, LoggedInProfileDir) {
   base::FilePath expected_default =
       base::FilePath().AppendASCII(chrome::kInitialProfile);
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   EXPECT_EQ(expected_default.value(),
             profile_manager->GetInitialProfileDir().value());
 
@@ skipping 10 matching lines @@
       content::NotificationService::AllSources(),
       content::Details<const user_manager::User>(active_user));
   base::FilePath expected_logged_in(
       chromeos::ProfileHelper::GetUserProfileDir(active_user->username_hash()));
   EXPECT_EQ(expected_logged_in.value(),
             profile_manager->GetInitialProfileDir().value());
   VLOG(1) << temp_dir_.path().Append(
       profile_manager->GetInitialProfileDir()).value();
 }
 
+// Switching the user should switch also the last used user.
+TEST_F(ProfileManagerTest, ActiveProfileChanged) {
+  ProfileManager* profile_manager = g_browser_process->profile_manager();
+  ASSERT_TRUE(profile_manager);
+
+  // Create and load two profiles.
+  const std::string user_name1 = "user1@example.com";
+  base::FilePath dest_path1 = temp_dir_.path().AppendASCII(user_name1);
+
+  MockObserver mock_observer;
+  EXPECT_CALL(mock_observer, OnProfileCreated(
+      testing::NotNull(), NotFail())).Times(testing::AtLeast(2));
+
+  CreateProfileAsync(profile_manager, user_name1, false, &mock_observer);
+  base::RunLoop().RunUntilIdle();
+
+  chromeos::FakeUserManager* user_manager = new chromeos::FakeUserManager();
+  chromeos::ScopedUserManagerEnabler enabler(user_manager);
+
+  PrefService* local_state = g_browser_process->local_state();
+  local_state->SetString(prefs::kProfileLastUsed, "");
+
+  const user_manager::User* active_user = user_manager->AddUser(user_name1);
+  user_manager->LoginUser(user_name1);
+
+  // None of the calls above should have changed the last user.
+  EXPECT_EQ("", local_state->GetString(prefs::kProfileLastUsed));
+
+  // The FakeUserManager will not switch the user either.
+  user_manager->SwitchActiveUser(user_name1);
+  EXPECT_EQ("", local_state->GetString(prefs::kProfileLastUsed));
+
+  // After triggering the LOGIN_USER_CHANGED observer call ourselves, the user
+  // has changed.
+  profile_manager->Observe(
+      chrome::NOTIFICATION_LOGIN_USER_CHANGED,
+      content::NotificationService::AllSources(),
+      content::Details<const user_manager::User>(active_user));
+  EXPECT_EQ("u-" + user_name1 + "-hash",
+      local_state->GetString(prefs::kProfileLastUsed));
+}
+
 #endif
 
 TEST_F(ProfileManagerTest, CreateAndUseTwoProfiles) {
   base::FilePath dest_path1 = temp_dir_.path();
   dest_path1 = dest_path1.Append(FILE_PATH_LITERAL("New Profile 1"));
 
   base::FilePath dest_path2 = temp_dir_.path();
   dest_path2 = dest_path2.Append(FILE_PATH_LITERAL("New Profile 2"));
 
   ProfileManager* profile_manager = g_browser_process->profile_manager();
@@ skipping 21 matching lines @@
 
   // Make sure any pending tasks run before we destroy the profiles.
     base::RunLoop().RunUntilIdle();
 
   TestingBrowserProcess::GetGlobal()->SetProfileManager(NULL);
 
   // Make sure history cleans up correctly.
   base::RunLoop().RunUntilIdle();
 }
 
-MATCHER(NotFail, "Profile creation failure status is not reported.") {
-  return arg == Profile::CREATE_STATUS_CREATED ||
-         arg == Profile::CREATE_STATUS_INITIALIZED;
-}
-
-MATCHER(SameNotNull, "The same non-NULL value for all calls.") {
-  if (!g_created_profile)
-    g_created_profile = arg;
-  return arg != NULL && arg == g_created_profile;
-}
-
 TEST_F(ProfileManagerTest, CreateProfileAsyncMultipleRequests) {
   g_created_profile = NULL;
 
   MockObserver mock_observer1;
   EXPECT_CALL(mock_observer1, OnProfileCreated(
       SameNotNull(), NotFail())).Times(testing::AtLeast(1));
   MockObserver mock_observer2;
   EXPECT_CALL(mock_observer2, OnProfileCreated(
       SameNotNull(), NotFail())).Times(testing::AtLeast(1));
   MockObserver mock_observer3;
@@ skipping 940 matching lines @@
                          dest_path2.BaseName().MaybeAsASCII());
   profile_manager->ScheduleProfileForDeletion(dest_path2,
                                               ProfileManager::CreateCallback());
   // Spin the message loop so that all the callbacks can finish running.
   base::RunLoop().RunUntilIdle();
 
   EXPECT_EQ(dest_path3, profile_manager->GetLastUsedProfile()->GetPath());
   EXPECT_EQ(profile_name3, local_state->GetString(prefs::kProfileLastUsed));
 }
 #endif  // !defined(OS_MACOSX)