Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 544383003: Fixing problem that after a browser crash in multi user mode, an incorrect user might show up. (Closed)

Created:
6 years, 3 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 3 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, rginda+watch_chromium.org, yoshiki+watch_chromium.org, dzhioev (left Google)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixing problem that after a browser crash in multi user mode, an incorrect user might show up. BUG=409226 TEST=unittest and visual Committed: https://crrev.com/24bb24431d367f4abdf107ec7cbbfa36d2641071 Cr-Commit-Position: refs/heads/master@{#293769}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Used Save version of GetProfileByUser instead #

Patch Set 3 : Moving function declaration into conditional section #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -25 lines) Patch
M chrome/browser/profiles/profile_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 3 chunks +26 lines, -14 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 3 chunks +53 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Mr4D (OOO till 08-26)
Please have a look!
6 years, 3 months ago (2014-09-06 02:39:35 UTC) #2
Dmitry Polukhin
LGTM + dzhioev@, FYI https://codereview.chromium.org/544383003/diff/1/chrome/browser/profiles/profile_manager.cc File chrome/browser/profiles/profile_manager.cc (right): https://codereview.chromium.org/544383003/diff/1/chrome/browser/profiles/profile_manager.cc#newcode825 chrome/browser/profiles/profile_manager.cc:825: chromeos::ProfileHelper::Get()->GetProfileByUserUnsafe(user)); I think you can ...
6 years, 3 months ago (2014-09-08 09:51:53 UTC) #3
Mr4D (OOO till 08-26)
Thanks for the quick review! https://codereview.chromium.org/544383003/diff/1/chrome/browser/profiles/profile_manager.cc File chrome/browser/profiles/profile_manager.cc (right): https://codereview.chromium.org/544383003/diff/1/chrome/browser/profiles/profile_manager.cc#newcode825 chrome/browser/profiles/profile_manager.cc:825: chromeos::ProfileHelper::Get()->GetProfileByUserUnsafe(user)); Done.
6 years, 3 months ago (2014-09-08 14:12:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/544383003/20001
6 years, 3 months ago (2014-09-08 14:12:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/6358)
6 years, 3 months ago (2014-09-08 14:31:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/544383003/40001
6 years, 3 months ago (2014-09-08 17:48:34 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as bb5748df4de9b9f86f5e37405357ef595bfbc572
6 years, 3 months ago (2014-09-08 19:32:59 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:47:39 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/24bb24431d367f4abdf107ec7cbbfa36d2641071
Cr-Commit-Position: refs/heads/master@{#293769}

Powered by Google App Engine
This is Rietveld 408576698