Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 544363002: [GCM] Adding GCMAccountMapper tests (Closed)

Created:
6 years, 3 months ago by fgorski
Modified:
6 years, 3 months ago
Reviewers:
jianli
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[GCM] Adding GCMAccountMapper tests 1) When the status is ADDING (adding message is sent), the token is refreshed. 2) When the status is REMOVING (removing message is sent), the token is added again. 3) updating multiple account mappings BUG=374969 R=jianli@chromium.org Committed: https://crrev.com/0df37a7cb82558acdbeca5ba4bd3020331ad1c85 Cr-Commit-Position: refs/heads/master@{#293744}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing CR comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -32 lines) Patch
M components/gcm_driver/gcm_account_mapper_unittest.cc View 1 22 chunks +312 lines, -32 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
fgorski
I've added tests that were missing in the big patch. PTAL
6 years, 3 months ago (2014-09-05 21:42:19 UTC) #1
jianli
lgtm https://codereview.chromium.org/544363002/diff/1/components/gcm_driver/gcm_account_mapper_unittest.cc File components/gcm_driver/gcm_account_mapper_unittest.cc (right): https://codereview.chromium.org/544363002/diff/1/components/gcm_driver/gcm_account_mapper_unittest.cc#newcode1 components/gcm_driver/gcm_account_mapper_unittest.cc:1: // Use of this source code is governed ...
6 years, 3 months ago (2014-09-05 22:52:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/544363002/20001
6 years, 3 months ago (2014-09-05 23:27:44 UTC) #4
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 05:29:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/544363002/20001
6 years, 3 months ago (2014-09-08 16:44:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a15249de25304c0d2173029bc22b2f136adac537
6 years, 3 months ago (2014-09-08 16:57:39 UTC) #9
Noel Gordon
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/554153003/ by noel@chromium.org. ...
6 years, 3 months ago (2014-09-09 00:49:55 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:46:52 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0df37a7cb82558acdbeca5ba4bd3020331ad1c85
Cr-Commit-Position: refs/heads/master@{#293744}

Powered by Google App Engine
This is Rietveld 408576698