Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 544313002: BrowserPlugin: Grab the correct viewsize to report to BrowserPluginGuestDelegate (Closed)

Created:
6 years, 3 months ago by Fady Samuel
Modified:
6 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

BrowserPlugin: Grab the correct viewsize to report to BrowserPluginGuestDelegate This size is used to determine when autosize has resized the guest. BUG=273089 Test=Launch chrome with --enable-embedded-extension-options, Open up chrome://extensions, click on Options for Goolge SPDY Proxy VPN and it shows a scrollbar. Committed: https://crrev.com/478927e20934f4c809047b7816876d1ec38e3bf0 Cr-Commit-Position: refs/heads/master@{#293611}

Patch Set 1 #

Patch Set 2 : Added test #

Patch Set 3 : Removed extra spaces #

Total comments: 2

Patch Set 4 : Improve test #

Patch Set 5 : Switched to property notation from attribute notation for readability #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 1 2 3 4 2 chunks +43 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
Fady Samuel
6 years, 3 months ago (2014-09-05 19:52:27 UTC) #2
danakj
LG can you test it?
6 years, 3 months ago (2014-09-05 19:52:56 UTC) #3
Fady Samuel
PTAL Dana.
6 years, 3 months ago (2014-09-05 21:08:26 UTC) #4
danakj
https://codereview.chromium.org/544313002/diff/40001/chrome/test/data/extensions/platform_apps/web_view/shim/main.js File chrome/test/data/extensions/platform_apps/web_view/shim/main.js (right): https://codereview.chromium.org/544313002/diff/40001/chrome/test/data/extensions/platform_apps/web_view/shim/main.js#newcode105 chrome/test/data/extensions/platform_apps/web_view/shim/main.js:105: webview.setAttribute('maxheight', 50); This makes a layer tree in the ...
6 years, 3 months ago (2014-09-05 21:13:19 UTC) #5
Fady Samuel
PTAL https://codereview.chromium.org/544313002/diff/40001/chrome/test/data/extensions/platform_apps/web_view/shim/main.js File chrome/test/data/extensions/platform_apps/web_view/shim/main.js (right): https://codereview.chromium.org/544313002/diff/40001/chrome/test/data/extensions/platform_apps/web_view/shim/main.js#newcode105 chrome/test/data/extensions/platform_apps/web_view/shim/main.js:105: webview.setAttribute('maxheight', 50); On 2014/09/05 21:13:19, danakj wrote: > ...
6 years, 3 months ago (2014-09-05 21:31:54 UTC) #6
danakj
LGTM
6 years, 3 months ago (2014-09-05 21:32:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/544313002/70001
6 years, 3 months ago (2014-09-05 21:36:37 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 03:38:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/544313002/70001
6 years, 3 months ago (2014-09-06 03:40:48 UTC) #13
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 09:42:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/544313002/70001
6 years, 3 months ago (2014-09-06 11:33:10 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:70001) as eda3dccca081e4923348dfa50ccde8c26f090c65
6 years, 3 months ago (2014-09-06 13:17:26 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:23 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/478927e20934f4c809047b7816876d1ec38e3bf0
Cr-Commit-Position: refs/heads/master@{#293611}

Powered by Google App Engine
This is Rietveld 408576698