Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 544303002: Fix findbugs warnings from https://codereview.chromium.org/406023002/ (Closed)

Created:
6 years, 3 months ago by Yaron
Modified:
6 years, 3 months ago
Reviewers:
boliu
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, AKVT
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix findbugs warnings from https://codereview.chromium.org/406023002/ It was rebased incorrectly and the new findbugs (from a move) weren't added. BUG=398263 R=boliu@chromium.org TBR=boliu Committed: https://chromium.googlesource.com/chromium/src/+/698b5a8388c10db134f79d681518848f7b705bdf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yaron
6 years, 3 months ago (2014-09-05 18:45:55 UTC) #2
boliu
On 2014/09/05 18:45:55, Yaron wrote: LGTM how did this happen?!
6 years, 3 months ago (2014-09-05 18:57:44 UTC) #3
Yaron
look at patchset 19: https://codereview.chromium.org/406023002/ bad rebase :( On Fri, Sep 5, 2014 at 11:57 ...
6 years, 3 months ago (2014-09-05 18:59:20 UTC) #4
Yaron
Committed patchset #1 (id:1) manually as 698b5a8 (presubmit successful).
6 years, 3 months ago (2014-09-05 19:02:37 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:41:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/698b5a8388c10db134f79d681518848f7b705bdf
Cr-Commit-Position: refs/heads/master@{#293564}

Powered by Google App Engine
This is Rietveld 408576698