Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 544283002: Update eme_player to handle MediaKeySession.generateRequest() (Closed)

Created:
6 years, 3 months ago by jrummell
Modified:
6 years, 3 months ago
Reviewers:
xhwang, ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update eme_player to handle MediaKeySession.generateRequest() Modify the createSession() call to use the new version (0 parameters) and call generateRequest() once it is available. BUG=358271 TEST=EME browser_tests pass with and without generateRequest() changes Committed: https://crrev.com/e42508865f7eeef0528c562d0dffc1fc9088cf22 Cr-Commit-Position: refs/heads/master@{#293975}

Patch Set 1 #

Total comments: 6

Patch Set 2 : spaces #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M media/test/data/eme_player_js/player_utils.js View 1 2 1 chunk +14 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jrummell
PTAL. This updates the browser_tests so they will continue to work once MediaKeySession.generateRequest() is implemented.
6 years, 3 months ago (2014-09-05 18:24:04 UTC) #2
ddorwin
https://codereview.chromium.org/544283002/diff/1/media/test/data/eme_player_js/player_utils.js File media/test/data/eme_player_js/player_utils.js (right): https://codereview.chromium.org/544283002/diff/1/media/test/data/eme_player_js/player_utils.js#newcode66 media/test/data/eme_player_js/player_utils.js:66: .catch (function(error) { remove the space here and below ...
6 years, 3 months ago (2014-09-08 17:50:09 UTC) #3
jrummell
Updated. https://codereview.chromium.org/544283002/diff/1/media/test/data/eme_player_js/player_utils.js File media/test/data/eme_player_js/player_utils.js (right): https://codereview.chromium.org/544283002/diff/1/media/test/data/eme_player_js/player_utils.js#newcode66 media/test/data/eme_player_js/player_utils.js:66: .catch (function(error) { On 2014/09/08 17:50:09, ddorwin wrote: ...
6 years, 3 months ago (2014-09-08 18:21:06 UTC) #4
jrummell
rebased now the PROMISES_SUPPORTED code is removed.
6 years, 3 months ago (2014-09-09 01:01:03 UTC) #5
ddorwin
Thanks. LGTM
6 years, 3 months ago (2014-09-09 17:23:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrummell@chromium.org/544283002/40001
6 years, 3 months ago (2014-09-09 17:25:16 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as bf2b3678a6aa5269826e8cd779584392865e4016
6 years, 3 months ago (2014-09-09 18:51:58 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:32 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e42508865f7eeef0528c562d0dffc1fc9088cf22
Cr-Commit-Position: refs/heads/master@{#293975}

Powered by Google App Engine
This is Rietveld 408576698