Roll libyuv 455c66b:147bbed

Roll libyuv 455c66b:147bbed

BUG=400684
Committed: https://crrev.com/dea44e9dc900904dc89f600e6a7b2947a1b54872
Cr-Commit-Position: refs/heads/master@{#298265}

[gordanac, 2014-09-05 16:43:54]

gordana.cmiljanovic@imgtec.com changed reviewers:
+ fbarchard@chromium.org

[gordanac, 2014-09-05 16:47:39]

I actually want to pull this mips related change: 3389f8e.

Still, is it ok to pull all?

[gordanac, 2014-09-09 08:37:21]

gordana.cmiljanovic@imgtec.com changed reviewers:
+ fbarchard@google.com
- fbarchard@chromium.org

[gordanac, 2014-09-09 08:39:42]

gordana.cmiljanovic@imgtec.com changed reviewers:
+ fbarchard@chromium.org

[gordanac, 2014-09-09 08:40:02]

PTAL.

[fbarchard, 2014-09-09 17:08:38]

lgtm and thanks.
Mind bumping it to head, which is 
fefc694ee9d72d4e134a889a42e3e12b6a70693d
so that we get the BUILD.gn fix a well?

[gordanac, 2014-09-10 10:17:09]

On 2014/09/09 17:08:38, fbarchard wrote:
> lgtm and thanks.
> Mind bumping it to head, which is 
> fefc694ee9d72d4e134a889a42e3e12b6a70693d
> so that we get the BUILD.gn fix a well?

Sure, I will roll to fefc694.

[gordanac, 2014-09-10 10:17:17]

The CQ bit was checked by gordana.cmiljanovic@imgtec.com

[gordanac, 2014-09-10 10:18:43]

The CQ bit was unchecked by gordana.cmiljanovic@imgtec.com

[gordanac, 2014-09-10 10:19:12]

gordana.cmiljanovic@imgtec.com changed reviewers:
+ gordana.cmiljanovic@imgtec.com
- Gordana.Cmiljanovic@imgtec.com

[gordanac, 2014-09-10 10:21:56]

The CQ bit was checked by gordana.cmiljanovic@imgtec.com

[commit-bot: I haz the power, 2014-09-10 10:22:36]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/Gordana.Cmiljanovic@imgtec.com/5442530...

[commit-bot: I haz the power, 2014-09-10 10:29:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 10:29:10]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[chromium-reviews, 2014-09-10 17:22:57]

Looks like I need to work on the arm64 version for android before we can
roll.
If its not immediately obvious, I'll disable neon.

On Wed, Sep 10, 2014 at 3:17 AM, <Gordana.Cmiljanovic@imgtec.com> wrote:

> On 2014/09/09 17:08:38, fbarchard wrote:
>
>> lgtm and thanks.
>> Mind bumping it to head, which is
>> fefc694ee9d72d4e134a889a42e3e12b6a70693d
>> so that we get the BUILD.gn fix a well?
>>
>
> Sure, I will roll to fefc694.
>
> https://codereview.chromium.org/544253002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[gordanac, 2014-09-12 11:39:06]

On 2014/09/10 17:22:57, chromium-reviews wrote:
> Looks like I need to work on the arm64 version for android before we can
> roll.
> If its not immediately obvious, I'll disable neon.
> 
> On Wed, Sep 10, 2014 at 3:17 AM, <mailto:Gordana.Cmiljanovic@imgtec.com>
wrote:
> 
> > On 2014/09/09 17:08:38, fbarchard wrote:
> >
> >> lgtm and thanks.
> >> Mind bumping it to head, which is
> >> fefc694ee9d72d4e134a889a42e3e12b6a70693d
> >> so that we get the BUILD.gn fix a well?
> >>
> >
> > Sure, I will roll to fefc694.
> >
> > https://codereview.chromium.org/544253002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Hi, do you have any update on this?

[paul.l..., 2014-09-25 00:09:52]

On 2014/09/12 11:39:06, gordanac wrote:
> On 2014/09/10 17:22:57, chromium-reviews wrote:
> > Looks like I need to work on the arm64 version for android before we can
> > roll.
> > If its not immediately obvious, I'll disable neon.

Hi Frank - Just checking back on this. I think Chromium is due to branch at end
of this week, and we need to get r1067 (3389f8e) and r1077 (fefc694) rolled in
by then if at all possible. Later change are fine for MIPS also, but those are
the ones we need. Thanks!

[chromium-reviews, 2014-09-26 23:22:51]

The arm code should be disabled in head for clang 3.4, so you could try
rolling to the latest libyuv.


On Wed, Sep 24, 2014 at 5:09 PM, <paul.lind@imgtec.com> wrote:

> On 2014/09/12 11:39:06, gordanac wrote:
>
>> On 2014/09/10 17:22:57, chromium-reviews wrote:
>> > Looks like I need to work on the arm64 version for android before we can
>> > roll.
>> > If its not immediately obvious, I'll disable neon.
>>
>
> Hi Frank - Just checking back on this. I think Chromium is due to branch
> at end
> of this week, and we need to get r1067 (3389f8e) and r1077 (fefc694)
> rolled in
> by then if at all possible. Later change are fine for MIPS also, but those
> are
> the ones we need. Thanks!
>
> https://codereview.chromium.org/544253002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[gordanac, 2014-09-29 11:00:18]

The CQ bit was checked by gordana.cmiljanovic@imgtec.com

[commit-bot: I haz the power, 2014-09-29 11:00:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/544253002/40001

[commit-bot: I haz the power, 2014-09-29 11:31:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 11:31:38]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[gordanac, 2014-09-29 17:05:22]

On 2014/09/29 11:31:38, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   android_arm64_dbg_recipe on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

Unfortunately, rolling to the latest libyuv failed to compile for android arm64.

[gordanac, 2014-10-02 13:45:53]

On 2014/09/29 17:05:22, gordanac wrote:
> On 2014/09/29 11:31:38, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   android_arm64_dbg_recipe on tryserver.chromium.linux
> >
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
> 
> Unfortunately, rolling to the latest libyuv failed to compile for android
arm64.

Arm64 build fixed here:
https://chromium.googlesource.com/external/libyuv/+/bb5cc129e5faca3c24ac6f83a...

I will give it a try.

[gordanac, 2014-10-02 13:50:23]

The CQ bit was checked by gordana.cmiljanovic@imgtec.com

[commit-bot: I haz the power, 2014-10-02 13:50:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/544253002/60001

[commit-bot: I haz the power, 2014-10-02 14:23:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-02 14:23:31]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[gordanac, 2014-10-06 14:51:32]

The CQ bit was checked by gordana.cmiljanovic@imgtec.com

[commit-bot: I haz the power, 2014-10-06 14:52:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/544253002/80001

[commit-bot: I haz the power, 2014-10-06 17:53:57]

Committed patchset #5 (id:80001) as 3d4fefdbd6b4b96563a1314ac64e7e7e1955cf07

[commit-bot: I haz the power, 2014-10-06 17:54:25]

Patchset 5 (id:??) landed as
https://crrev.com/dea44e9dc900904dc89f600e6a7b2947a1b54872
Cr-Commit-Position: refs/heads/master@{#298265}

[ilja, 2014-10-06 20:53:18]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/633683003/ by ihf@chromium.org.

The reason for reverting is: This has broken the ChromeOS build. Please make
sure crbug.com/420763 is addressed before landing again..

[fbarchard, 2014-10-06 21:23:15]

On 2014/10/06 20:53:18, ilja wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
> https://codereview.chromium.org/633683003/ by mailto:ihf@chromium.org.
> 
> The reason for reverting is: This has broken the ChromeOS build. Please make
> sure crbug.com/420763 is addressed before landing again..

The issue with AVX compiles was resolved in a newer version of libyuv by
checking compiler version and disabling AVX for older compilers.

[gordanac, 2014-10-07 09:58:56]

On 2014/10/06 21:23:15, fbarchard wrote:
> On 2014/10/06 20:53:18, ilja wrote:
> > A revert of this CL (patchset #5 id:80001) has been created in
> > https://codereview.chromium.org/633683003/ by mailto:ihf@chromium.org.
> > 
> > The reason for reverting is: This has broken the ChromeOS build. Please make
> > sure crbug.com/420763 is addressed before landing again..
> 
> The issue with AVX compiles was resolved in a newer version of libyuv by
> checking compiler version and disabling AVX for older compilers.

Hi Frank,
which exact libyuv version should be ok to roll in to Chromium now?

Latest roll to 147bbed corresponds to:
https://code.google.com/p/libyuv/source/detail?r=1109
which means that AVX related change
https://code.google.com/p/libyuv/source/detail?r=1105
is included.

Please advise how to proceed.

[Ben Murdoch, 2014-10-10 13:40:51]

Gordana, can you try rolling to libyuv r1118:
https://code.google.com/p/libyuv/source/detail?r=1118

That should be the fix that's needed.

[gordanac, 2014-10-10 14:33:20]

On 2014/10/10 13:40:51, Ben Murdoch wrote:
> Gordana, can you try rolling to libyuv r1118:
> https://code.google.com/p/libyuv/source/detail?r=1118
> 
> That should be the fix that's needed.

I will try roll to:
https://chromium.googlesource.com/external/libyuv/+/4d46be3930146bf9bdff7c175...

[gordanac, 2014-10-10 14:53:26]

I didn't know if I can reuse this CL, so here is a new one:

https://codereview.chromium.org/643123002/