src/images/SkImageDecoder_libgif.cpp - Issue 544233002: "NULL !=" = NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/images/SkImageDecoder_libgif.cpp

Issue 544233002: "NULL !=" = NULL (Closed) Base URL: https://skia.googlesource.com/skia.git@are

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/images/SkImageDecoder_libgif.cpp

diff --git a/src/images/SkImageDecoder_libgif.cpp b/src/images/SkImageDecoder_libgif.cpp

index 0c8461f893e5f3e938ac3e1c1fb371ae6bf000d9..745f4e11f11116fbd876318bfbe4131de8efee0d 100644

--- a/src/images/SkImageDecoder_libgif.cpp

+++ b/src/images/SkImageDecoder_libgif.cpp

@@ -194,7 +194,7 @@ static bool skip_src_rows(GifFileType* gif, uint8_t* dst, int width, int rowsToS

static void sanitize_indexed_bitmap(SkBitmap* bm) {

if ((kIndex_8_SkColorType == bm->colorType()) && !(bm->empty())) {

SkAutoLockPixels alp(*bm);

- if (NULL != bm->getPixels()) {

+ if (bm->getPixels()) {

SkColorTable* ct = bm->getColorTable(); // Index8 must have it.

SkASSERT(ct != NULL);

uint32_t count = ct->count();

« no previous file with comments | « src/images/SkImageDecoder_ktx.cpp ('k') | src/images/SkImageDecoder_libpng.cpp » ('j') | no next file with comments »