Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Unified Diff: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java

Issue 544223003: Add SetSupportsQuic method to explicitly specify server that supports QUIC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
diff --git a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
index d5a5c9b4e8c7dfffbeae5c680816d082ee2accce..58a2d94b827b2bee70b375c0cc24406c5c274dd8 100644
--- a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
+++ b/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
@@ -86,6 +86,21 @@ public class ChromiumUrlRequestContext {
nativeStopNetLog(mChromiumUrlRequestContextAdapter);
}
+ /**
+ * Explicitly mark |server| as supporting QUIC with given |probability|.
+ * Note that DISK CACHE must be enabled to take advantage or 0RTT QUIC.
+ *
+ * @param server URL of the server that supports QUIC
+ * @param alternatePort to use for QUIC
+ * @param probability that server supports QUIC (0..1)
mmenke 2014/09/05 17:20:34 This seems like a bad idea to me.
mef 2014/09/05 18:15:42 Done.
+ */
+ public void setSupportsQuic(String server,
mmenke 2014/09/05 17:20:33 Suggest calling this setQuicHint, which leaves a b
mmenke 2014/09/05 17:20:34 I strongly suggest we throw an exception if |serve
mef 2014/09/05 18:15:42 Done.
mef 2014/09/05 18:15:42 Done.
Charles 2014/09/05 18:16:22 This isn't very useful, as API goes - a normal use
mef 2014/09/05 19:07:28 Acknowledged. This is geared towards advanced user
+ int alternatePort,
+ float probability) {
+ nativeSetSupportsQuic(mChromiumUrlRequestContextAdapter, server,
+ alternatePort, probability);
+ }
+
@CalledByNative
private void initNetworkThread() {
Thread.currentThread().setName("ChromiumNet");
@@ -125,14 +140,18 @@ public class ChromiumUrlRequestContext {
String userAgent, int loggingLevel, String config);
private native void nativeReleaseRequestContextAdapter(
- long ChromiumUrlRequestContextAdapter);
+ long chromiumUrlRequestContextAdapter);
private native void nativeInitializeStatistics();
private native String nativeGetStatisticsJSON(String filter);
private native void nativeStartNetLogToFile(
- long ChromiumUrlRequestContextAdapter, String fileName);
+ long chromiumUrlRequestContextAdapter, String fileName);
+
+ private native void nativeStopNetLog(long chromiumUrlRequestContextAdapter);
- private native void nativeStopNetLog(long ChromiumUrlRequestContextAdapter);
+ private native void nativeSetSupportsQuic(
+ long chromiumUrlRequestContextAdapter, String server,
+ int alternatePort, float probability);
}
« no previous file with comments | « components/cronet/android/chromium_url_request_context.cc ('k') | components/cronet/android/url_request_context_adapter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698