Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 544183002: Opt out of composited scrolling with border radius. (Closed)

Created:
6 years, 3 months ago by Ian Vollick
Modified:
6 years, 3 months ago
Reviewers:
hartmanng
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink, danakj
Project:
blink
Visibility:
Public.

Description

Opt out of composited scrolling with border radius. This currently causes correctness and memory issues due to the way the compositor handles masking out the corners. Let's punt on this for now. BUG=409984, 365828 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181484

Patch Set 1 #

Patch Set 2 : Update expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + LayoutTests/compositing/overflow/scroller-with-border-radius.html View 3 chunks +7 lines, -8 lines 0 comments Download
A LayoutTests/compositing/overflow/scroller-with-border-radius-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Ian Vollick
6 years, 3 months ago (2014-09-05 14:31:53 UTC) #2
hartmanng
lgtm
6 years, 3 months ago (2014-09-05 14:32:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/544183002/1
6 years, 3 months ago (2014-09-05 14:33:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/23644)
6 years, 3 months ago (2014-09-05 15:34:57 UTC) #7
Ian Vollick
On 2014/09/05 15:34:57, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 3 months ago (2014-09-05 16:46:21 UTC) #8
hartmanng
Yeah, those tests were testing the previous partially-broken implementation (as per http://crbug.com/365828), where scroll children ...
6 years, 3 months ago (2014-09-05 16:49:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/544183002/20001
6 years, 3 months ago (2014-09-05 16:54:30 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 23:05:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181484

Powered by Google App Engine
This is Rietveld 408576698