chrome/browser/resources/options/chromeos/onc_data.js - Issue 544173013: Make network settings functions more closely match networkingPrivate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/chromeos/onc_data.js

Issue 544173013: Make network settings functions more closely match networkingPrivate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_279351_internet_options_10c

Patch Set: Feedback Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/chromeos/network_list.js ('k') | chrome/browser/ui/webui/options/chromeos/internet_options_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/chromeos/onc_data.js

diff --git a/chrome/browser/resources/options/chromeos/onc_data.js b/chrome/browser/resources/options/chromeos/onc_data.js

index 877bdcb9e1f37f0b0e7164e6c4d06cb64d3df6c7..5a45e6ab15c6a4643990419341ccccdd83a881e6 100644

--- a/chrome/browser/resources/options/chromeos/onc_data.js

+++ b/chrome/browser/resources/options/chromeos/onc_data.js

@@ -159,21 +159,6 @@ cr.define('cr.onc', function() {

/**

- * Updates the properties of |data_| from the properties in |update|.

- * Note: this only looks at top level entries, so if a dictionary is

- * updated the entire dictionary is written over. TODO(stevenjb):

- * eliminate this function when |data_| contains only ONC entries and

- * any updates consist of complete ONC dictionaries.

- * @param {Object} update Dictionary containing the updated properties.

- */

- updateData: function(update) {

- for (var prop in update) {

- if (prop in this.data_)

- this.data_[prop] = update[prop];

- }

- },

- /**

* Get the effective value from a Managed property ONC dictionary.

* @param {Object} property The managed property ONC dictionary.

* @return {*} The effective value or undefined.