LayoutTests/media/video-positive-start-time.html - Issue 544173012: Add LayoutTest for media with positive start times.

Side by Side Diff: LayoutTests/media/video-positive-start-time.html

Issue 544173012: Add LayoutTest for media with positive start times. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: testharness.js Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>video with a postive start time</title>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <div id="log"></div>

	6 <video controls></video>

	7 <script>

	8 async_test(function(t) {

	9 var video = document.querySelector('video');

	10 video.src = 'resources/test-positive-start-time.webm';

	11

	12 var seekTime = 5;

	13

	14 // Verify initial start time is correct.

	15 video.onloadeddata = t.step_func(function() {

	16 console.log(video.currentTime);
	philipj_slow 2014/09/18 20:07:43 Why console.log here? Will it should up somewhere? Why console.log here? Will it should up somewhere? DaleCurtis 2014/09/18 20:17:11 Whoops, that's an accidental include on my part. S Show quoted text On 2014/09/18 20:07:43, philipj wrote: > Why console.log here? Will it should up somewhere? Whoops, that's an accidental include on my part. Sorry.
	17 assert_equals(video.currentTime, 4.253, 'currentTime');

	18 video.currentTime = seekTime;
	philipj_slow 2014/09/18 20:07:43 Verifying that seeking works as expected is good, Verifying that seeking works as expected is good, but I would perhaps doing it in a separate test or tests. If you haven't already, have a look at the steps for "Once enough of the media data has been fetched to determine the duration of the media resource, its dimensions, and other metadata" in the spec: https://html.spec.whatwg.org/#media-data-processing-steps-list Here the "earliest possible position", "default playback start position " and "initial playback position" interact, so I think testing should focus on this algorithm. In other words: - One test that sets currentTime = 5 right before or after src - One test that sets src to 'resources/test-positive-start-time.webm#t=2' Both should have currentTime 5 in the loadedmetadata event, which should be followed by a seeked event. DaleCurtis 2014/09/18 20:17:12 I had trouble running multiple tests in the same f Show quoted text On 2014/09/18 20:07:43, philipj wrote: > Verifying that seeking works as expected is good, but I would perhaps doing it > in a separate test or tests. If you haven't already, have a look at the steps > for "Once enough of the media data has been fetched to determine the duration of > the media resource, its dimensions, and other metadata" in the spec: > https://html.spec.whatwg.org/#media-data-processing-steps-list > > Here the "earliest possible position", "default playback start position " and > "initial playback position" interact, so I think testing should focus on this > algorithm. > > In other words: > > - One test that sets currentTime = 5 right before or after src > - One test that sets src to 'resources/test-positive-start-time.webm#t=2' > > Both should have currentTime 5 in the loadedmetadata event, which should be > followed by a seeked event. I had trouble running multiple tests in the same file since the tests run concurrently and use the same video tag. Are you suggesting creating a separate test file or chaining them based upon completion somehow? Hmm, why would the currentTime=2 end up with a currentTime of 5? It should be the earliest available position which is 4.253 no? philipj_slow 2014/09/18 20:38:17 My thought was simply having multiple files, but i Show quoted text On 2014/09/18 20:17:12, DaleCurtis wrote: > On 2014/09/18 20:07:43, philipj wrote: > > Verifying that seeking works as expected is good, but I would perhaps doing it > > in a separate test or tests. If you haven't already, have a look at the steps > > for "Once enough of the media data has been fetched to determine the duration > of > > the media resource, its dimensions, and other metadata" in the spec: > > https://html.spec.whatwg.org/#media-data-processing-steps-list > > > > Here the "earliest possible position", "default playback start position " and > > "initial playback position" interact, so I think testing should focus on this > > algorithm. > > > > In other words: > > > > - One test that sets currentTime = 5 right before or after src > > - One test that sets src to 'resources/test-positive-start-time.webm#t=2' > > > > Both should have currentTime 5 in the loadedmetadata event, which should be > > followed by a seeked event. > > I had trouble running multiple tests in the same file since the tests run > concurrently and use the same video tag. Are you suggesting creating a separate > test file or chaining them based upon completion somehow? My thought was simply having multiple files, but if you ever want to have multiple tests in the same file, you can create a video element per test. I wouldn't really recommend it though, when such tests are flaky it makes it harder to figure out the cause. Show quoted text > Hmm, why would the currentTime=2 end up with a currentTime of 5? It should be > the earliest available position which is 4.253 no? Sorry, I meant currentTime=5 :)
	19 });

	20

	21 // Verify the seeked location matches the timestamps in the file.

	22 video.onseeked = t.step_func(function() {

	23 console.log(video.currentTime);

	24 assert_equals(video.currentTime, seekTime, 'currentTime');

	25 // FIXME: Once Chrome correctly exposes seekable ranges for media with

	26 // positive start times, verify video.seekable.start(0) here.

	27 t.done();

	28 })

	29 });

	30 </script>

OLD	NEW

« no previous file with comments | « LayoutTests/media/resources/test-positive-start-time.webm ('k') | no next file » | no next file with comments »