LayoutTests/media/video-positive-start-time.html - Issue 544173012: Add LayoutTest for media with positive start times.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/video-positive-start-time.html

Issue 544173012: Add LayoutTest for media with positive start times. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Style. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <body onload="start()">

	4 <p>Load a video with a postive start time, ensure video.currentTime is 4.253</ p>

	5 <video></video>

	6 </body>

	7

	8 <script src="video-test.js"></script>
	philipj_slow 2014/09/17 11:25:36 You can't really put anything after </body>, the H You can't really put anything after </body>, the HTML parser will simply move it to inside <body>. I would like new tests to use testharness.js wherever possible, and this is how this test would translate: <!DOCTYPE html> <title>video with a postive start time</title> <script src="../resources/testharness.js"></script> <script src="../resources/testharnessreport.js"></script> <div id="log"></div> <video></video> <script> async_test(function(t) { var video = document.querySelector('video'); video.src = 'resources/test-positive-start-time.webm'; video.onloadeddata = t.step_func(function() { assert_equals(video.currentTime, 4.253, 'currentTime'); // FIXME: Once Chrome correctly exposes seekable ranges for media with // positive start times, verify video.seekable.start(0) here. t.done(); }); }); </script> No expectation file is then needed. Please also add a test using 'resources/test-positive-start-time.webm#t=5' and assert that the correct offset wins, which per spec is 5. DaleCurtis 2014/09/18 01:54:04 Done. Thanks for the drive-by! Show quoted text On 2014/09/17 11:25:36, philipj wrote: > You can't really put anything after </body>, the HTML parser will simply move it > to inside <body>. > > I would like new tests to use testharness.js wherever possible, and this is how > this test would translate: > > <!DOCTYPE html> > <title>video with a postive start time</title> > <script src="../resources/testharness.js"></script> > <script src="../resources/testharnessreport.js"></script> > <div id="log"></div> > <video></video> > <script> > async_test(function(t) { > var video = document.querySelector('video'); > video.src = 'resources/test-positive-start-time.webm'; > video.onloadeddata = t.step_func(function() { > assert_equals(video.currentTime, 4.253, 'currentTime'); > // FIXME: Once Chrome correctly exposes seekable ranges for media with > // positive start times, verify video.seekable.start(0) here. > t.done(); > }); > }); > </script> > > No expectation file is then needed. > > Please also add a test using 'resources/test-positive-start-time.webm#t=5' and > assert that the correct offset wins, which per spec is 5. Done. Thanks for the drive-by!
	9 <script src="media-file.js"></script>

	10 <script>

	11 waitForEventOnce('loadeddata', function() {

	12 testExpected('video.currentTime', 4.253, '==');

	13 // FIXME: Once Chrome correctly exposes seekable ranges for media with

	14 // positive start times, verify video.seekable.start(0) here.

	15 endTest();

	16 });

	17

	18 function start() {

	19 video.src = 'resources/test-positive-start-time.webm';

	20 }

	21 </script>

OLD	NEW