Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 544173006: Fix animation distance. (Closed)

Created:
6 years, 3 months ago by rsadam
Modified:
6 years, 3 months ago
Reviewers:
bshe
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix animation distance. BUG=355572 Committed: https://crrev.com/3293cbdadb5d001832c7d6ce7918a5a90b8ba8b6 Cr-Commit-Position: refs/heads/master@{#295075}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M ui/keyboard/keyboard_controller.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_controller.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
rsadam
6 years, 3 months ago (2014-09-15 17:23:37 UTC) #2
bshe
On 2014/09/15 17:23:37, rsadam wrote: you probably need to update a few keyboard_unittests
6 years, 3 months ago (2014-09-15 20:39:55 UTC) #3
rsadam
Done!
6 years, 3 months ago (2014-09-16 14:32:29 UTC) #4
bshe
lgtm with nits https://codereview.chromium.org/544173006/diff/40001/ui/keyboard/keyboard_controller.cc File ui/keyboard/keyboard_controller.cc (right): https://codereview.chromium.org/544173006/diff/40001/ui/keyboard/keyboard_controller.cc#newcode373 ui/keyboard/keyboard_controller.cc:373: transform.Translate(0, keyboard::kAnimationDistance); nit: I believe "keyboard" ...
6 years, 3 months ago (2014-09-16 14:43:38 UTC) #5
rsadam
https://codereview.chromium.org/544173006/diff/40001/ui/keyboard/keyboard_controller.cc File ui/keyboard/keyboard_controller.cc (right): https://codereview.chromium.org/544173006/diff/40001/ui/keyboard/keyboard_controller.cc#newcode373 ui/keyboard/keyboard_controller.cc:373: transform.Translate(0, keyboard::kAnimationDistance); On 2014/09/16 14:43:38, bshe wrote: > nit: ...
6 years, 3 months ago (2014-09-16 14:46:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/544173006/60001
6 years, 3 months ago (2014-09-16 14:47:32 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001) as e30e2ab7f3332e4ba333454fa0e11d997b3498e1
6 years, 3 months ago (2014-09-16 15:45:17 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 15:46:41 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3293cbdadb5d001832c7d6ce7918a5a90b8ba8b6
Cr-Commit-Position: refs/heads/master@{#295075}

Powered by Google App Engine
This is Rietveld 408576698