Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 544173002: move SK_SUPPORT_LEGACY_PUBLIC_IMAGEINFO_FIELDS into header (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

move SK_SUPPORT_LEGACY_PUBLIC_IMAGEINFO_FIELDS into header TBR=schenney@chromium.org Committed: https://crrev.com/ae6c6a39a2bc6eb17c4bac6628db57e16f2bc743 Cr-Commit-Position: refs/heads/master@{#293526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
reed1
6 years, 3 months ago (2014-09-05 13:57:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/544173002/1
6 years, 3 months ago (2014-09-05 13:58:59 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-05 13:59:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/544173002/1
6 years, 3 months ago (2014-09-05 14:15:53 UTC) #8
Stephen Chennney
I'm not an owner. Any number of Skia folks are, including some ex-Skia folks: alokp@chromium.org ...
6 years, 3 months ago (2014-09-05 14:18:12 UTC) #9
robertphillips
lgtm
6 years, 3 months ago (2014-09-05 14:20:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as d8c79de15ca8d2500e9cb3175df6a9f6449e7268
6 years, 3 months ago (2014-09-05 15:41:23 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:39:46 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ae6c6a39a2bc6eb17c4bac6628db57e16f2bc743
Cr-Commit-Position: refs/heads/master@{#293526}

Powered by Google App Engine
This is Rietveld 408576698