Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 544123003: Add in a missing call to propagate the extension choices to the Save As dialog. (Closed)

Created:
6 years, 3 months ago by erikwright (departed)
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add in a missing call to propagate the extension choices to the Save As dialog. BUG=407972 Committed: https://crrev.com/a8cb7294296066c661aa16a2d7dc64673ff8905a Cr-Commit-Position: refs/heads/master@{#293715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/utility/shell_handler_win.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
erikwright (departed)
sky: this missing call led to the "extensions" (filters) dropdown being empty in the Save ...
6 years, 3 months ago (2014-09-05 18:48:23 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-05 19:28:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/544123003/1
6 years, 3 months ago (2014-09-05 19:30:14 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 01:34:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/544123003/1
6 years, 3 months ago (2014-09-06 02:11:21 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 08:14:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/544123003/1
6 years, 3 months ago (2014-09-08 13:38:52 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 52aaa4ba04dd9c50b5d17071d51cd5cf2ac935e4
6 years, 3 months ago (2014-09-08 13:42:27 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:57 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8cb7294296066c661aa16a2d7dc64673ff8905a
Cr-Commit-Position: refs/heads/master@{#293715}

Powered by Google App Engine
This is Rietveld 408576698