Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 544103002: mojo: java core API: Allow interaction with native handles (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
ppi
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: java core API: Allow interaction with native handles This adds API to convert handle to and from int to allow interaction with native code. R=ppi@chromium.org Committed: https://crrev.com/0e0d095c8f6e21e042fc8c6978a026f8bdf77515 Cr-Commit-Position: refs/heads/master@{#293703}

Patch Set 1 #

Patch Set 2 : Remove spurious blank line. #

Total comments: 8

Patch Set 3 : Follow review #

Messages

Total messages: 7 (1 generated)
qsr
6 years, 3 months ago (2014-09-05 12:19:39 UTC) #1
ppi
Lgtm % nits, thanks! https://codereview.chromium.org/544103002/diff/20001/mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java File mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java (right): https://codereview.chromium.org/544103002/diff/20001/mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java#newcode821 mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java:821: * Testing that conversion to ...
6 years, 3 months ago (2014-09-08 09:23:05 UTC) #2
qsr
https://codereview.chromium.org/544103002/diff/20001/mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java File mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java (right): https://codereview.chromium.org/544103002/diff/20001/mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java#newcode821 mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java:821: * Testing that conversion to native is correct. On ...
6 years, 3 months ago (2014-09-08 09:44:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/544103002/40001
6 years, 3 months ago (2014-09-08 09:44:47 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as f870becc1075e8d7ebffe5d3e33c92712cbafc34
6 years, 3 months ago (2014-09-08 10:43:10 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:37 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0e0d095c8f6e21e042fc8c6978a026f8bdf77515
Cr-Commit-Position: refs/heads/master@{#293703}

Powered by Google App Engine
This is Rietveld 408576698