Source/core/editing/VisibleSelection.cpp - Issue 544083002: Avoid allocating temporary ranges in connection with text and character iterators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisibleSelection.cpp

Issue 544083002: Avoid allocating temporary ranges in connection with text and character iterators. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address review comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/VisibleSelection.cpp

diff --git a/Source/core/editing/VisibleSelection.cpp b/Source/core/editing/VisibleSelection.cpp

index 13543de8bc310dcb3a9b7cc4b3c069aae5686b52..e9fa94cca02efdb656f07edda814c6026f469a1f 100644

--- a/Source/core/editing/VisibleSelection.cpp

+++ b/Source/core/editing/VisibleSelection.cpp

@@ -313,7 +313,7 @@ void VisibleSelection::appendTrailingWhitespace()

UChar c = charIt.characterAt(0);

if ((!isSpaceOrNewline(c) && c != noBreakSpace) || c == '\n')

break;

- m_end = charIt.range()->endPosition();

+ m_end = charIt.endPosition();

changed = true;

}

if (changed)

« no previous file with comments | « Source/core/editing/TextIterator.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »