Avoid allocating temporary ranges in connection with text and character iterators.

Source/core/editing/PlainTextRange.cpp

Index: Source/core/editing/PlainTextRange.cpp
diff --git a/Source/core/editing/PlainTextRange.cpp b/Source/core/editing/PlainTextRange.cpp
index 986799b8d47d5d01c8aacb92d14991c471168388..b0680dbacccca02b6195d3c6883c381dd2896672 100644
--- a/Source/core/editing/PlainTextRange.cpp
+++ b/Source/core/editing/PlainTextRange.cpp
@@ -87,7 +87,7 @@ PassRefPtrWillBeRawPtr<Range> PlainTextRange::createRangeFor(const ContainerNode
     if (!start() && !length() && it.atEnd()) {
         textRunRange = it.range();
 
-        resultRange->setStart(textRunRange->startContainer(), 0, ASSERT_NO_EXCEPTION);
+        resultRange->setStart(it.startContainer(), 0, ASSERT_NO_EXCEPTION);
         resultRange->setEnd(textRunRange->startContainer(), 0, ASSERT_NO_EXCEPTION);

[yosin_UTC9, 2014/09/08 01:55:19]

nit: It seems we can replace L91 |textRunRange->startContainer()| to
|it.startContainer()| as L90.

If so, we can get rid of |Range| object creation at |it.range()|.

TODO: We should rename |TextIterator::range()| to |CreateRange()| or another to
indicate this is expensive operation rather than accessing cheap property
access.

[Mads Ager (chromium), 2014/09/08 08:50:46]

Yes, good catch, not sure why I didn't notice that. Thanks!
 
Yes, we should.

 
         return resultRange.release();