Issue 544043002: Next base/macros.h cleanup step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 544043002: Next base/macros.h cleanup step. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer

Modified:
6 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -50 lines)			Patch
M	src/api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/base/macros.h	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/base/platform/platform-cygwin.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/base/platform/platform-freebsd.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/base/platform/platform-linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/base/platform/platform-macos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/base/platform/platform-openbsd.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/base/platform/platform-qnx.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/base/platform/platform-solaris.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/base/platform/platform-win32.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/utils.h	View	2 chunks	+17 lines, -1 line	0 comments	Download
M	test/cctest/test-parsing.cc	View	13 chunks	+26 lines, -23 lines	0 comments	Download

Total messages: 2 (0 generated)

Benedikt Meurer

6 years, 3 months ago (2014-09-08 04:44:37 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23760 (presubmit successful).