Linux video capture: handle devices that don't enumerate any frame rates

Linux video capture: handle devices that don't enumerate any frame rates

BUG=412284
TEST=Check output from DVLOG(1) << device.name() << " " << supported_format.ToString() in VideoCaptureDeviceFactoryLinux::GetDeviceSupportedFormats. For a Kinect Camera, it will now list: Microsoft Kinect Camera resolution: 640x480, fps: 0.000000, pixel format: UYUY

Committed: https://crrev.com/7c653cbed4467e77e9df90e076e9d837887c67a7
Cr-Commit-Position: refs/heads/master@{#293923}

[magjed_chromium, 2014-09-05 07:31:16]

magjed@chromium.org changed reviewers:
+ mcasas@chromium.org, perkj@chromium.org

[magjed_chromium, 2014-09-05 07:31:30]

PTAL

[magjed_chromium, 2014-09-05 09:09:35]

PTAL

https://codereview.chromium.org/544033002/diff/20001/media/video/capture/linu...
File media/video/capture/linux/video_capture_device_factory_linux.cc (right):

https://codereview.chromium.org/544033002/diff/20001/media/video/capture/linu...
media/video/capture/linux/video_capture_device_factory_linux.cc:185: for
(std::list<float>::iterator it = frame_rates.begin();
C++11 range-based for loops are not allowed in chromium?

[perkj_chrome, 2014-09-05 12:04:58]

code is ok but please
file a bug and describe the problem such as the user sees it.

Then add 
BUG= bug number.
TEST= how to test that this works. 

Have you verified that AllocateAndStart do get 0 as frame rate back when trying
to start the device?
What happens if mandatory minFrameRate is set?

https://codereview.chromium.org/544033002/diff/40001/media/video/capture/linu...
File media/video/capture/linux/video_capture_device_factory_linux.cc (right):

https://codereview.chromium.org/544033002/diff/40001/media/video/capture/linu...
media/video/capture/linux/video_capture_device_factory_linux.cc:187: ++it) {
nit, fits on line above.

[magjed_chromium, 2014-09-09 09:10:06]

I have verified that AllocateAndStart do get 0.0 as frame rate. If minFrameRate
is set (>0), it will filter out zero frame rate formats.

In OnAllocateAndStart for Linux, if the device can set the frame rate (supports
VIDIOC_G_PARM and V4L2_CAP_TIMEPERFRAME), and the frame rate is 0, it will be
converted to kTypicalFramerate (=30).
Kinect does not support to set the frame rate, so I haven't verified this
behaviour.

https://codereview.chromium.org/544033002/diff/40001/media/video/capture/linu...
File media/video/capture/linux/video_capture_device_factory_linux.cc (right):

https://codereview.chromium.org/544033002/diff/40001/media/video/capture/linu...
media/video/capture/linux/video_capture_device_factory_linux.cc:187: ++it) {
On 2014/09/05 12:04:58, perkj wrote:
> nit, fits on line above.

Done. FYI, clang-format wants "++it" on a separate line.

[perkj_chrome, 2014-09-09 10:44:31]

lgtm

[magjed_chromium, 2014-09-09 11:08:30]

The CQ bit was checked by magjed@chromium.org

[commit-bot: I haz the power, 2014-09-09 11:09:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/magjed@chromium.org/544033002/60001

[commit-bot: I haz the power, 2014-09-09 12:09:32]

Committed patchset #4 (id:60001) as cea5061f1b0df643b6a12ce20a185d44d0bb9d17

[commit-bot: I haz the power, 2014-09-10 03:52:53]

Patchset 4 (id:??) landed as
https://crrev.com/7c653cbed4467e77e9df90e076e9d837887c67a7
Cr-Commit-Position: refs/heads/master@{#293923}