Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 544023002: ServiceWorker: Remove navigator.serviceWorker.{installing,waiting,active} (Chromium) (Closed)

Created:
6 years, 3 months ago by nhiroki
Modified:
6 years, 3 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Remove navigator.serviceWorker.{installing,waiting,active} (Chromium) These attributes are gone: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-container Blink: https://codereview.chromium.org/541943003/ BUG=404982 TEST=content_unittests --gtest_filter=ServiceWorker* TEST=run_webkit_tests.py --debug http/tests/serviceworker/ Committed: https://crrev.com/a5eebf69901f34a7ad0aef15d7c2eec73bc130f1 Cr-Commit-Position: refs/heads/master@{#293501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M content/child/service_worker/web_service_worker_provider_impl.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nhiroki
Ptal, thanks!
6 years, 3 months ago (2014-09-05 06:57:01 UTC) #2
horo
lgtm
6 years, 3 months ago (2014-09-05 10:30:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/544023002/1
6 years, 3 months ago (2014-09-05 10:35:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2198a6a343489c8ee5863b0395280c70d71fbcc7
6 years, 3 months ago (2014-09-05 11:50:52 UTC) #6
azarchs
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/549473002/ by azarchs@chromium.org. ...
6 years, 3 months ago (2014-09-05 14:24:46 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:38:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5eebf69901f34a7ad0aef15d7c2eec73bc130f1
Cr-Commit-Position: refs/heads/master@{#293501}

Powered by Google App Engine
This is Rietveld 408576698