Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: Source/core/frame/Frame.h

Issue 544013005: Simplify window.closed testing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/Frame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/Frame.h
diff --git a/Source/core/frame/Frame.h b/Source/core/frame/Frame.h
index fc4820a39d356845c767035bf6fba0adc6f83175..498cb77c81bfd740d26d1fdc0c02b6131f656796 100644
--- a/Source/core/frame/Frame.h
+++ b/Source/core/frame/Frame.h
@@ -98,9 +98,6 @@ public:
// method.
bool isRemoteFrameTemporary() const { return m_remotePlatformLayer; }
- bool hasBeenClosed() const { return m_hasBeenClosed; }
- void setHasBeenClosed();
-
protected:
Frame(FrameClient*, FrameHost*, FrameOwner*);
@@ -114,14 +111,6 @@ protected:
private:
FrameClient* m_client;
blink::WebLayer* m_remotePlatformLayer;
-
- // The closing of a frame by the embedder may not trigger the
- // immediate release of this Frame object -- there might be
- // other RefPtrs to the Frame, up the stack or elsewhere.
- //
- // Hence, keep a separate flag that's set when the frame is
- // closed. It is consulted by window.closed.
- bool m_hasBeenClosed;
};
inline FrameClient* Frame::client() const
« no previous file with comments | « no previous file | Source/core/frame/Frame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698