Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 544013005: Simplify window.closed testing. (Closed)

Created:
6 years, 3 months ago by sof
Modified:
6 years, 3 months ago
CC:
dcheng, blink-reviews, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Simplify window.closed testing. Instead of keeping a separate Frame flag, have LocalDOMWindow::closed consider the presence of a FrameHost on the frame. It'll be cleared during detach and impending frame closure, and is observationally equivalent to keeping an unnecessary extra flag. R=dcheng,ager BUG=414658 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182201

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M Source/core/frame/Frame.h View 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/frame/Frame.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
sof
Please take a look. As per dcheng's suggestion ( https://codereview.chromium.org/538323003/#msg22 ) to consider FrameHost instead.
6 years, 3 months ago (2014-09-17 12:48:06 UTC) #2
Mads Ager (chromium)
LGTM Nice simplification; thanks for pointing that out dcheng. :)
6 years, 3 months ago (2014-09-17 12:50:13 UTC) #3
dcheng
Thanks! LGTM
6 years, 3 months ago (2014-09-17 17:12:58 UTC) #4
sof
On 2014/09/17 12:50:13, Mads Ager (chromium) wrote: > LGTM > > Nice simplification; thanks for ...
6 years, 3 months ago (2014-09-17 19:07:22 UTC) #5
tkent
lgtm
6 years, 3 months ago (2014-09-17 23:19:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/544013005/1
6 years, 3 months ago (2014-09-17 23:19:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 182201
6 years, 3 months ago (2014-09-18 00:01:09 UTC) #9
haraken
6 years, 3 months ago (2014-09-20 08:14:39 UTC) #10
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698