tests/common/register_set.h - Issue 544003002: NonSFI mode: Enable compiling exception_test for NonSFI NaCl on ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/common/register_set.h

Issue 544003002: NonSFI mode: Enable compiling exception_test for NonSFI NaCl on ARM (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/common/register_set.h

diff --git a/tests/common/register_set.h b/tests/common/register_set.h

index 5bb747d174b1c8fa1d02e322504c2c2d95fbf7ee..c7b0a590667600981708ffbf2fc8407e428fa1b0 100644

--- a/tests/common/register_set.h

+++ b/tests/common/register_set.h

@@ -240,7 +240,7 @@ extern const uint8_t kX86FlagBits[5];

#def_func ":\n" \

/* Push most of "struct NaClSignalContext" in reverse order. */ \

"push $0\n" /* Leave space for flags */ \

- "push $" #def_func "\n" /* Fill out prog_ctr with known value */ \

+ "push $" #def_func "@got\n" /* Fill out prog_ctr with known value */ \

Junichi Uekawa 2014/09/09 12:23:58 This works around having relocation in code, but w

Junichi Uekawa 2014/09/09 15:28:03 Looking at try results of course it does, but then

"push %edi\n" \

"push %esi\n" \

"push %ebp\n" \

« SConstruct ('K') | « SConstruct ('k') | tests/exception_test/exception_test.c » ('j') | tests/exception_test/exception_test.c » ('J')