Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: SConstruct

Issue 544003002: NonSFI mode: Enable compiling exception_test for NonSFI NaCl on ARM (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: remove dependency to IRT implementation for now. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | site_scons/site_tools/naclsdk.py » ('j') | tests/exception_test/exception_test.c » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #! -*- python -*- 1 #! -*- python -*-
2 # Copyright (c) 2012 The Native Client Authors. All rights reserved. 2 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import atexit 6 import atexit
7 import json 7 import json
8 import os 8 import os
9 import platform 9 import platform
10 import re 10 import re
(...skipping 675 matching lines...) Expand 10 before | Expand all | Expand 10 after
686 'run_prctl_test', 686 'run_prctl_test',
687 'run_printf_test', 687 'run_printf_test',
688 'run_pwrite_test', 688 'run_pwrite_test',
689 'run_sigaction_test', 689 'run_sigaction_test',
690 'run_signal_sigbus_test', 690 'run_signal_sigbus_test',
691 'run_signal_test', 691 'run_signal_test',
692 'run_socket_test', 692 'run_socket_test',
693 'run_stack_alignment_test', 693 'run_stack_alignment_test',
694 'run_syscall_test', 694 'run_syscall_test',
695 'run_thread_test', 695 'run_thread_test',
696
697 # TODO(uekawa): Enable exception test when implementation is ready.
698 'run_exception_test', # TODO(uekawa): disable before submitting because it fails.
Junichi Uekawa 2014/09/30 00:35:30 I think I should disable this configuration before
Mark Seaborn 2014/09/30 01:12:01 Yes, you'd need to remove this line as per your co
696 ]) 699 ])
697 700
698 701
699 # If a test is not in one of these suites, it will probally not be run on a 702 # If a test is not in one of these suites, it will probally not be run on a
700 # regular basis. These are the suites that will be run by the try bot or that 703 # regular basis. These are the suites that will be run by the try bot or that
701 # a large number of users may run by hand. 704 # a large number of users may run by hand.
702 MAJOR_TEST_SUITES = set([ 705 MAJOR_TEST_SUITES = set([
703 'small_tests', 706 'small_tests',
704 'medium_tests', 707 'medium_tests',
705 'large_tests', 708 'large_tests',
(...skipping 2311 matching lines...) Expand 10 before | Expand all | Expand 10 after
3017 """ 3020 """
3018 if env.Bit('bitcode'): 3021 if env.Bit('bitcode'):
3019 # For each architecture, we only attempt to make our inline 3022 # For each architecture, we only attempt to make our inline
3020 # assembly code work with one untrusted-code toolchain. For x86, 3023 # assembly code work with one untrusted-code toolchain. For x86,
3021 # we target GCC, but not PNaCl/Clang, because the latter's 3024 # we target GCC, but not PNaCl/Clang, because the latter's
3022 # assembly support has various quirks that we don't want to have 3025 # assembly support has various quirks that we don't want to have
3023 # to debug. For ARM, we target PNaCl/Clang, because that is the 3026 # to debug. For ARM, we target PNaCl/Clang, because that is the
3024 # only current ARM toolchain. One day, we will have an ARM GCC 3027 # only current ARM toolchain. One day, we will have an ARM GCC
3025 # toolchain, and we will no longer need to use inline assembly 3028 # toolchain, and we will no longer need to use inline assembly
3026 # with PNaCl/Clang at all. 3029 # with PNaCl/Clang at all.
3027 if not (env.Bit('target_arm') or env.Bit('target_mips32')): 3030 #
3028 return False 3031 # For Non-SFI NaCl we use inline assembly in PNaCl/Clang.
3032 if not (env.Bit('target_arm') or env.Bit('target_mips32')
3033 or env.Bit('nonsfi_nacl')):
3034 return False
3029 # Inline assembly does not work in pexes. 3035 # Inline assembly does not work in pexes.
3030 if env.Bit('pnacl_generate_pexe'): 3036 if env.Bit('pnacl_generate_pexe'):
3031 return False 3037 return False
3032 env.AddBiasForPNaCl() 3038 env.AddBiasForPNaCl()
3033 env.PNaClForceNative() 3039 env.PNaClForceNative()
3034 return True 3040 return True
3035 3041
3036 nacl_env.AddMethod(AllowInlineAssembly) 3042 nacl_env.AddMethod(AllowInlineAssembly)
3037 3043
3038 3044
(...skipping 980 matching lines...) Expand 10 before | Expand all | Expand 10 after
4019 nacl_env.ValidateSdk() 4025 nacl_env.ValidateSdk()
4020 4026
4021 if BROKEN_TEST_COUNT > 0: 4027 if BROKEN_TEST_COUNT > 0:
4022 msg = "There are %d broken tests." % BROKEN_TEST_COUNT 4028 msg = "There are %d broken tests." % BROKEN_TEST_COUNT
4023 if GetOption('brief_comstr'): 4029 if GetOption('brief_comstr'):
4024 msg += " Add --verbose to the command line for more information." 4030 msg += " Add --verbose to the command line for more information."
4025 print msg 4031 print msg
4026 4032
4027 # separate warnings from actual build output 4033 # separate warnings from actual build output
4028 Banner('B U I L D - O U T P U T:') 4034 Banner('B U I L D - O U T P U T:')
OLDNEW
« no previous file with comments | « no previous file | site_scons/site_tools/naclsdk.py » ('j') | tests/exception_test/exception_test.c » ('J')

Powered by Google App Engine
This is Rietveld 408576698