NonSFI mode: Enable compiling exception_test for NonSFI NaCl on ARM

tests/exception_test/exception_test.c

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <assert.h>
 #include <errno.h>
 #include <pthread.h>
 #include <setjmp.h>
@@ skipping 104 matching lines @@
   longjmp(g_jmp_buf, 1);
 }
 
 void simple_exception_handler(struct NaClExceptionContext *regs) {
   return_from_exception_handler();
 }
 
 void exception_handler(struct NaClExceptionContext *context);
 REGS_SAVER_FUNC_NOPROTO(exception_handler, exception_handler_wrapped);
 
+__attribute__((__used__))

[Junichi Uekawa, 2014/09/09 12:23:58]

inline assembly is something external in pexe, so code would look like it's
unused if only assembly is used.

 void exception_handler_wrapped(struct NaClSignalContext *entry_regs) {
   struct NaClExceptionContext *context =
       (struct NaClExceptionContext *) RegsGetArg1(entry_regs);
   struct NaClExceptionPortableContext *portable =
       nacl_exception_context_get_portable(context);
 
   printf("handler called\n");
 
   assert(context->size == (uintptr_t) (portable + 1) - (uintptr_t) context);
   assert(context->portable_context_size ==
@@ skipping 58 matching lines @@
 #endif
 
   return_from_exception_handler();
 }
 
 void test_exception_stack_with_size(char *stack, size_t stack_size) {
   if (0 != nacl_exception_set_handler(exception_handler)) {
     printf("failed to set exception handler\n");
     exit(4);
   }
-  if (0 != nacl_exception_set_stack(stack, stack_size)) {
-    printf("failed to set alt stack\n");
-    exit(5);
+  if (!NONSFI_MODE) {
+    /* TODO(uekawa): Implement set_stack on Non-SFI NaCl. */
+    if (0 != nacl_exception_set_stack(stack, stack_size)) {
+      printf("failed to set alt stack\n");
+      exit(5);
+    }
+    g_registered_stack = stack;
+    g_registered_stack_size = stack_size;
   }
-  g_registered_stack = stack;
-  g_registered_stack_size = stack_size;
 
   char crash_stack[0x1000];
   RegsFillTestValues(&g_regs_at_crash, /* seed= */ 0);
   g_regs_at_crash.stack_ptr = (uintptr_t) crash_stack + sizeof(crash_stack);
   g_regs_at_crash.prog_ctr = (uintptr_t) prog_ctr_at_crash;
   RegsApplySandboxConstraints(&g_regs_at_crash);
 #if defined(__arm__)
   /* crash_at_known_address clobbers r0. */
   g_regs_at_crash.r0 = 0;
 #endif
@@ skipping 100 matching lines @@
   if (!setjmp(g_jmp_buf)) {
     __asm__("hlt");
     exit(1);
   }
   printf("Testing ud2a (an illegal instruction)...\n");
   if (!setjmp(g_jmp_buf)) {
     __asm__("ud2a");
     exit(1);
   }
   printf("Testing integer division by zero...\n");
+#if !NONSFI_MODE
+  /* TODO(uekawa): Enable on Non-SFI NaCl. */
   if (!setjmp(g_jmp_buf)) {
     uint32_t result;
     __asm__ volatile("idivb %1"
                      : "=a"(result)
                      : "r"((uint8_t) 0), "a"((uint16_t) 1));
     exit(1);
   }
 #endif
+#endif
 
   /* Clear the jmp_buf to prevent it from being reused accidentally. */
   memset(g_jmp_buf, 0, sizeof(g_jmp_buf));
 }
 
 
-#if defined(__i386__) || defined(__x86_64__)
+#if !NONSFI_MODE && (defined(__i386__) || defined(__x86_64__))
+/* TODO(uekawa): Enable on Non-SFI NaCl */
 
 int get_x86_direction_flag(void);
 
 void test_get_x86_direction_flag(void) {
   /*
    * Sanity check:  Ensure that get_x86_direction_flag() works.  We
    * avoid calling assert() with the flag set, because that might not
    * work.
    */
   assert(get_x86_direction_flag() == 0);
@@ skipping 35 matching lines @@
 
 void run_test(const char *test_name, void (*test_func)(void)) {
   printf("Running %s...\n", test_name);
   test_func();
 }
 
 #define RUN_TEST(test_func) (run_test(#test_func, test_func))
 
 int TestMain(void) {
   RUN_TEST(test_exceptions_minimally);
-  RUN_TEST(test_exception_stack_alignments);
-  RUN_TEST(test_getting_previous_handler);
-  RUN_TEST(test_invalid_handlers);
+  if (!NONSFI_MODE) {
+    /*
+     * The following tests are for SFI invariants which do not hold
+     * true for Non-SFI mode.
+     */
+    RUN_TEST(test_exception_stack_alignments);
+    RUN_TEST(test_getting_previous_handler);
+    RUN_TEST(test_invalid_handlers);
+  }
   /* pthread_join() is broken under qemu-arm. */
   if (getenv("UNDER_QEMU_ARM") == NULL)
     RUN_TEST(test_exceptions_on_non_main_thread);
   RUN_TEST(test_catching_various_exception_types);
 
-#if defined(__i386__) || defined(__x86_64__)
+#if !NONSFI_MODE && (defined(__i386__) || defined(__x86_64__))
+  /* TODO(uekawa): Enable these test for Non-SFI mode too. */
   RUN_TEST(test_get_x86_direction_flag);
   RUN_TEST(test_unsetting_x86_direction_flag);
 #endif
 
   fprintf(stderr, "** intended_exit_status=0\n");
   return 0;
 }
 
 int main(void) {
   return RunTests(TestMain);
 }