Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 543973003: Update sync status in Desktop. (Closed)

Created:
6 years, 3 months ago by iseki
Modified:
6 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update sync status in Desktop. The progress bar of sync status in Desktop Notification is not updated due to issue 400636. BUG=408931 TEST=manually 1. Copy local file to Drive 2. Start sync 3. Close Files.app 4. Observe the Notification Committed: https://crrev.com/9a89052b1d611ef815bacf97db18e970024498f9 Cr-Commit-Position: refs/heads/master@{#293472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ui/file_manager/file_manager/background/js/drive_sync_handler.js View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
iseki
Please take a look.
6 years, 3 months ago (2014-09-05 04:32:10 UTC) #2
hirono
Oops, sorry for missing it. lgtm.
6 years, 3 months ago (2014-09-05 04:35:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/543973003/1
6 years, 3 months ago (2014-09-05 04:39:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6d1fd3fe139b623eb4a0a20cffef37acea839bfe
6 years, 3 months ago (2014-09-05 08:17:00 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:37:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a89052b1d611ef815bacf97db18e970024498f9
Cr-Commit-Position: refs/heads/master@{#293472}

Powered by Google App Engine
This is Rietveld 408576698