Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Issue 543953003: Adding DumpAccessibilityTree Tests (8 of 20) (Closed)

Created:
6 years, 3 months ago by shreeramk
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall, dtseng, Peter Lundblad
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding DumpAccessibilityTree Tests (8 of 20) HTML Tags: object, ins, mark, i, legend, frameset, caption, body, th Aria role: row, spinbutton Aria state/property: aria-atomic BUG=170580 Committed: https://crrev.com/711d923e3b9dd778e482f991f280e6dd937d1abf Cr-Commit-Position: refs/heads/master@{#294739}

Patch Set 1 #

Patch Set 2 : Adding expectations file for mac #

Total comments: 1

Patch Set 3 : Adding expectations for android #

Patch Set 4 : #

Total comments: 5

Patch Set 5 : Adding @MAC-ALLOW to get proper attribute values #

Patch Set 6 : Rebasing changes #

Patch Set 7 : Fixing build errors on win and android #

Total comments: 1

Patch Set 8 : #

Patch Set 9 : Adding aria-row.html #

Patch Set 10 : Skipping some expectations #

Patch Set 11 : Updating aria-row to get correct results #

Total comments: 4

Patch Set 12 : #

Patch Set 13 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -28 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 9 chunks +40 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-atomic.html View 1 2 3 4 5 6 7 8 1 chunk +12 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-atomic-expected-android.txt View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-atomic-expected-mac.txt View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-atomic-expected-win.txt View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-row.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +19 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-row-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +14 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-row-expected-mac.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +20 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-row-expected-win.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +20 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/body.html View 1 2 3 4 5 1 chunk +6 lines, -8 lines 0 comments Download
A content/test/data/accessibility/body-expected-android.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/body-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/body-expected-win.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/caption.html View 1 chunk +22 lines, -0 lines 0 comments Download
A content/test/data/accessibility/caption-expected-android.txt View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A content/test/data/accessibility/caption-expected-mac.txt View 1 1 chunk +20 lines, -0 lines 0 comments Download
A content/test/data/accessibility/caption-expected-win.txt View 1 chunk +20 lines, -0 lines 0 comments Download
A content/test/data/accessibility/frameset.html View 5 6 7 1 chunk +9 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/frameset-expected-android.txt View 1 2 3 4 5 6 7 8 9 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/frameset-expected-mac.txt View 1 3 4 1 chunk +16 lines, -0 lines 0 comments Download
A content/test/data/accessibility/frameset-expected-win.txt View 1 3 4 1 chunk +16 lines, -0 lines 0 comments Download
A content/test/data/accessibility/i.html View 3 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/i-expected-android.txt View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/i-expected-mac.txt View 1 3 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/i-expected-win.txt View 3 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/ins.html View 3 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/ins-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/ins-expected-mac.txt View 1 3 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/ins-expected-win.txt View 3 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/legend.html View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +17 lines, -0 lines 0 comments Download
A content/test/data/accessibility/legend-expected-android.txt View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/legend-expected-mac.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +9 lines, -0 lines 0 comments Download
A content/test/data/accessibility/legend-expected-win.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A content/test/data/accessibility/mark.html View 3 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/mark-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/mark-expected-mac.txt View 1 3 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/mark-expected-win.txt View 3 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/object.html View 5 6 7 1 chunk +9 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/object-expected-android.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/object-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/object-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/table-simple.html View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +7 lines, -5 lines 0 comments Download
M content/test/data/accessibility/table-simple-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +7 lines, -7 lines 0 comments Download
M content/test/data/accessibility/table-simple-expected-mac.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 25 (4 generated)
shreeramk
PTAL!
6 years, 3 months ago (2014-09-05 13:34:04 UTC) #2
shreeramk
Not sure why for object AXUnknown is coming. https://codereview.chromium.org/543953003/diff/20001/content/test/data/accessibility/frameset-expected-mac.txt File content/test/data/accessibility/frameset-expected-mac.txt (right): https://codereview.chromium.org/543953003/diff/20001/content/test/data/accessibility/frameset-expected-mac.txt#newcode2 content/test/data/accessibility/frameset-expected-mac.txt:2: AXUnknown ...
6 years, 3 months ago (2014-09-05 13:37:08 UTC) #3
dmazzoni
Thanks *very much* for these. Note that DumpAccessibilityTree only dumps some of the most common ...
6 years, 3 months ago (2014-09-08 05:10:27 UTC) #4
shreeramk
For aria-row I ll take care in the next patch set. In this patch set ...
6 years, 3 months ago (2014-09-09 11:30:44 UTC) #5
shreeramk
On 2014/09/09 11:30:44, shreeram.k wrote: > For aria-row I ll take care in the next ...
6 years, 3 months ago (2014-09-09 14:25:32 UTC) #6
dmazzoni
On 2014/09/09 14:25:32, shreeram.k wrote: > On 2014/09/09 11:30:44, shreeram.k wrote: > > For aria-row ...
6 years, 3 months ago (2014-09-09 21:28:20 UTC) #7
dmazzoni
https://codereview.chromium.org/543953003/diff/120001/content/test/data/accessibility/aria-atomic-expected-win.txt File content/test/data/accessibility/aria-atomic-expected-win.txt (right): https://codereview.chromium.org/543953003/diff/120001/content/test/data/accessibility/aria-atomic-expected-win.txt#newcode4 content/test/data/accessibility/aria-atomic-expected-win.txt:4: ROLE_SYSTEM_CLIENT FOCUSABLE atomic:true container-atomic:true Thanks, this looks perfect
6 years, 3 months ago (2014-09-09 21:28:41 UTC) #8
shreeramk
I added expectations file aria-row.html for windows. On Android its giving TIMEOUT. And hence getting ...
6 years, 3 months ago (2014-09-10 11:46:36 UTC) #9
shreeramk
On 2014/09/10 11:46:36, shreeram.k wrote: > I added expectations file aria-row.html for windows. > > ...
6 years, 3 months ago (2014-09-10 16:19:07 UTC) #10
shreeramk
PTAL! Now all done!
6 years, 3 months ago (2014-09-11 06:38:17 UTC) #11
dmazzoni
Just a few more quick things then this should be ready. Thanks! https://codereview.chromium.org/543953003/diff/200001/content/test/data/accessibility/ins-expected-android.txt File content/test/data/accessibility/ins-expected-android.txt ...
6 years, 3 months ago (2014-09-11 17:02:38 UTC) #12
shreeramk
On 2014/09/11 17:02:38, dmazzoni wrote: > https://codereview.chromium.org/543953003/diff/200001/content/test/data/accessibility/legend-expected-mac.txt > File content/test/data/accessibility/legend-expected-mac.txt (right): > > https://codereview.chromium.org/543953003/diff/200001/content/test/data/accessibility/legend-expected-mac.txt#newcode2 > ...
6 years, 3 months ago (2014-09-11 19:27:05 UTC) #13
dmazzoni
On Thu, Sep 11, 2014 at 12:27 PM, <shreeram.k@samsung.com> wrote: > legend is a html ...
6 years, 3 months ago (2014-09-11 19:40:34 UTC) #14
shreeramk
PTAL! 1. Bug filed for mark.html and ins.html related to space - crbug.com/413531 2. Added ...
6 years, 3 months ago (2014-09-12 17:24:50 UTC) #15
dmazzoni
lgtm Great, thanks!
6 years, 3 months ago (2014-09-12 17:33:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/543953003/240001
6 years, 3 months ago (2014-09-12 17:34:29 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/4062) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/15042) win_chromium_compile_dbg ...
6 years, 3 months ago (2014-09-12 17:52:52 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/543953003/240001
6 years, 3 months ago (2014-09-13 06:33:05 UTC) #22
commit-bot: I haz the power
Committed patchset #13 (id:240001) as da5ef67d8cdb8ed79facef901d7882631b8bb677
6 years, 3 months ago (2014-09-13 07:18:05 UTC) #23
commit-bot: I haz the power
Patchset 13 (id:??) landed as https://crrev.com/711d923e3b9dd778e482f991f280e6dd937d1abf Cr-Commit-Position: refs/heads/master@{#294739}
6 years, 3 months ago (2014-09-13 07:21:54 UTC) #24
jam
6 years, 3 months ago (2014-09-14 06:20:37 UTC) #25

Powered by Google App Engine
This is Rietveld 408576698