Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 54393002: Fix uint32-to-smi conversion in Lithium (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: your wish is my command Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1984 matching lines...) Expand 10 before | Expand all | Expand 10 after
1995 : NULL; 1995 : NULL;
1996 LNumberTagU* result = new(zone()) LNumberTagU(value, temp); 1996 LNumberTagU* result = new(zone()) LNumberTagU(value, temp);
1997 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result))); 1997 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result)));
1998 } else { 1998 } else {
1999 LNumberTagI* result = new(zone()) LNumberTagI(value); 1999 LNumberTagI* result = new(zone()) LNumberTagI(value);
2000 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result))); 2000 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result)));
2001 } 2001 }
2002 } else if (to.IsSmi()) { 2002 } else if (to.IsSmi()) {
2003 HValue* val = instr->value(); 2003 HValue* val = instr->value();
2004 LOperand* value = UseRegister(val); 2004 LOperand* value = UseRegister(val);
2005 LInstruction* result = 2005 LInstruction* result = val->CheckFlag(HInstruction::kUint32)
2006 DefineSameAsFirst(new(zone()) LInteger32ToSmi(value)); 2006 ? DefineSameAsFirst(new(zone()) LUint32ToSmi(value))
2007 : DefineSameAsFirst(new(zone()) LInteger32ToSmi(value));
2007 if (val->HasRange() && val->range()->IsInSmiRange()) { 2008 if (val->HasRange() && val->range()->IsInSmiRange()) {
2008 return result; 2009 return result;
2009 } 2010 }
2010 return AssignEnvironment(result); 2011 return AssignEnvironment(result);
2011 } else { 2012 } else {
2012 ASSERT(to.IsDouble()); 2013 ASSERT(to.IsDouble());
2013 if (instr->value()->CheckFlag(HInstruction::kUint32)) { 2014 if (instr->value()->CheckFlag(HInstruction::kUint32)) {
2014 LOperand* temp = FixedTemp(xmm1); 2015 LOperand* temp = FixedTemp(xmm1);
2015 return DefineAsRegister( 2016 return DefineAsRegister(
2016 new(zone()) LUint32ToDouble(UseRegister(instr->value()), temp)); 2017 new(zone()) LUint32ToDouble(UseRegister(instr->value()), temp));
(...skipping 718 matching lines...) Expand 10 before | Expand all | Expand 10 after
2735 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2736 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2736 LOperand* object = UseRegister(instr->object()); 2737 LOperand* object = UseRegister(instr->object());
2737 LOperand* index = UseTempRegister(instr->index()); 2738 LOperand* index = UseTempRegister(instr->index());
2738 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2739 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2739 } 2740 }
2740 2741
2741 2742
2742 } } // namespace v8::internal 2743 } } // namespace v8::internal
2743 2744
2744 #endif // V8_TARGET_ARCH_IA32 2745 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698