Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 54393002: Fix uint32-to-smi conversion in Lithium (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: your wish is my command Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1996 matching lines...) Expand 10 before | Expand all | Expand 10 after
2007 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result))); 2007 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result)));
2008 } else if (val->HasRange() && val->range()->IsInSmiRange()) { 2008 } else if (val->HasRange() && val->range()->IsInSmiRange()) {
2009 return DefineAsRegister(new(zone()) LSmiTag(value)); 2009 return DefineAsRegister(new(zone()) LSmiTag(value));
2010 } else { 2010 } else {
2011 LNumberTagI* result = new(zone()) LNumberTagI(value); 2011 LNumberTagI* result = new(zone()) LNumberTagI(value);
2012 return AssignEnvironment(AssignPointerMap(DefineAsRegister(result))); 2012 return AssignEnvironment(AssignPointerMap(DefineAsRegister(result)));
2013 } 2013 }
2014 } else if (to.IsSmi()) { 2014 } else if (to.IsSmi()) {
2015 HValue* val = instr->value(); 2015 HValue* val = instr->value();
2016 LOperand* value = UseRegister(val); 2016 LOperand* value = UseRegister(val);
2017 LInstruction* result = 2017 LInstruction* result = val->CheckFlag(HInstruction::kUint32)
2018 DefineSameAsFirst(new(zone()) LInteger32ToSmi(value)); 2018 ? DefineSameAsFirst(new(zone()) LUint32ToSmi(value))
2019 : DefineSameAsFirst(new(zone()) LInteger32ToSmi(value));
2019 if (val->HasRange() && val->range()->IsInSmiRange()) { 2020 if (val->HasRange() && val->range()->IsInSmiRange()) {
2020 return result; 2021 return result;
2021 } 2022 }
2022 return AssignEnvironment(result); 2023 return AssignEnvironment(result);
2023 } else { 2024 } else {
2024 ASSERT(to.IsDouble()); 2025 ASSERT(to.IsDouble());
2025 if (instr->value()->CheckFlag(HInstruction::kUint32)) { 2026 if (instr->value()->CheckFlag(HInstruction::kUint32)) {
2026 return DefineAsRegister( 2027 return DefineAsRegister(
2027 new(zone()) LUint32ToDouble(UseRegister(instr->value()))); 2028 new(zone()) LUint32ToDouble(UseRegister(instr->value())));
2028 } else { 2029 } else {
(...skipping 629 matching lines...) Expand 10 before | Expand all | Expand 10 after
2658 2659
2659 2660
2660 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2661 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2661 LOperand* object = UseRegister(instr->object()); 2662 LOperand* object = UseRegister(instr->object());
2662 LOperand* index = UseRegister(instr->index()); 2663 LOperand* index = UseRegister(instr->index());
2663 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2664 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2664 } 2665 }
2665 2666
2666 2667
2667 } } // namespace v8::internal 2668 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698