Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 543913002: Hook up postMessages to WebRemoteFrameClient (Closed)

Created:
6 years, 3 months ago by Nate Chapin
Modified:
6 years, 3 months ago
Reviewers:
nasko, abarth-chromium
CC:
abarth-chromium, blink-reviews, dcheng, dglazkov+blink, gavinp+loader_chromium.org, jamesr, Nate Chapin
Project:
blink
Visibility:
Public.

Description

Hook up postMessages to WebRemoteFrameClient WebRemoteFrameClient only inherits from WebFrameClient as a temporary measure, separate them. willCheckAndDispatchMessageEvent() is used to give the embedder a chance to postMessage() externally. Move it from FrameLoaderClient to FrameClient and implement it in RemoteFrame and WebRemoteFrameImpl. This is step 3 of 3 in getting WebRemoteFrameClient up and running. BUG=411066 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181932

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Fix webkit_unit_tests compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -22 lines) Patch
M Source/core/frame/FrameClient.h View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 1 chunk +2 lines, -6 lines 0 comments Download
M Source/web/RemoteFrameClient.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/RemoteFrameClient.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.h View 1 2 3 3 chunks +6 lines, -2 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.h View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M public/web/WebRemoteFrame.h View 1 chunk +3 lines, -2 lines 0 comments Download
M public/web/WebRemoteFrameClient.h View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Nate Chapin
6 years, 3 months ago (2014-09-09 23:35:50 UTC) #2
abarth-chromium
lgtm
6 years, 3 months ago (2014-09-11 20:36:51 UTC) #4
abarth-chromium
Can we unit test this feature?
6 years, 3 months ago (2014-09-11 20:37:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/543913002/40001
6 years, 3 months ago (2014-09-11 20:37:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/10310)
6 years, 3 months ago (2014-09-11 20:54:54 UTC) #8
abarth-chromium
LGTM
6 years, 3 months ago (2014-09-12 19:45:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/543913002/60001
6 years, 3 months ago (2014-09-12 19:49:00 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 21:08:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 181932

Powered by Google App Engine
This is Rietveld 408576698