chrome/browser/extensions/extension_toolbar_model_unittest.cc - Issue 543893002: Random fixes through Chrome for scoped_reftpr T* removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_toolbar_model_unittest.cc

Issue 543893002: Random fixes through Chrome for scoped_reftpr T* removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc ('k') | chrome/browser/extensions/location_bar_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_toolbar_model_unittest.cc

diff --git a/chrome/browser/extensions/extension_toolbar_model_unittest.cc b/chrome/browser/extensions/extension_toolbar_model_unittest.cc

index 9b90bb5c9ad56c19427925a6e5f9e78a55608d57..88836324fb000e5f70a842371d6ace50ad23d036 100644

--- a/chrome/browser/extensions/extension_toolbar_model_unittest.cc

+++ b/chrome/browser/extensions/extension_toolbar_model_unittest.cc

@@ -293,13 +293,13 @@ TEST_F(ExtensionToolbarModelUnitTest, BasicExtensionToolbarModelTest) {

// We should now find our extension in the model.

EXPECT_EQ(1u, observer()->inserted_count());

EXPECT_EQ(1u, num_toolbar_items());

- EXPECT_EQ(extension2, GetExtensionAtIndex(0u));

+ EXPECT_EQ(extension2.get(), GetExtensionAtIndex(0u));

// Should be a no-op, but still fires the events.

toolbar_model()->MoveExtensionIcon(extension2.get(), 0);

EXPECT_EQ(1u, observer()->moved_count());

EXPECT_EQ(1u, num_toolbar_items());

- EXPECT_EQ(extension2, GetExtensionAtIndex(0u));

+ EXPECT_EQ(extension2.get(), GetExtensionAtIndex(0u));

// Remove the extension and verify.

ASSERT_TRUE(RemoveExtension(extension2));