Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 543893002: Random fixes through Chrome for scoped_reftpr T* removal. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
avayvod+watch_chromium.org, cbentzel+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, erikwright+watch_chromium.org, extensions-reviews_chromium.org, hclam+watch_chromium.org, hguihot+watch_chromium.org, hubbe+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, mikhal+watch_chromium.org, miu+watch_chromium.org, piman+watch_chromium.org, pwestin+watch_google.com, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Random fixes for scoped_refptr operator T* removal. BUG=110610 TBR=caitkp, michaeln, rockot, sievers, sky, willchan Committed: https://crrev.com/37fac505ffd432f088abbc5056e7c72ca59ff017 Cr-Commit-Position: refs/heads/master@{#293453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M base/test/test_pending_task.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_toolbar_model_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/location_bar_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/location_bar_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/quota_policy_channel_id_store.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/net/quota_policy_channel_id_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/history_data_store.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M components/variations/variations_seed_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb_device_handle_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/common/blob/scoped_file.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
dcheng
The (hopefully) final patch before scoped_refptr's implicit T* conversion can be disabled on Linux builds. ...
6 years, 3 months ago (2014-09-04 22:40:11 UTC) #2
michaeln
storage lgtm
6 years, 3 months ago (2014-09-04 22:41:42 UTC) #4
Ken Rockot(use gerrit already)
extensions and device lgtm
6 years, 3 months ago (2014-09-04 22:42:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/543893002/1
6 years, 3 months ago (2014-09-04 22:43:42 UTC) #6
no sievers
On 2014/09/04 22:40:11, dcheng (OOO) wrote: > The (hopefully) final patch before scoped_refptr's implicit T* ...
6 years, 3 months ago (2014-09-04 22:51:30 UTC) #7
willchan no longer on Chromium
lgtm
6 years, 3 months ago (2014-09-04 23:06:25 UTC) #8
sky
LGTM
6 years, 3 months ago (2014-09-05 00:07:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/543893002/1
6 years, 3 months ago (2014-09-05 02:03:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/10435)
6 years, 3 months ago (2014-09-05 04:50:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/543893002/1
6 years, 3 months ago (2014-09-05 05:00:31 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7e2963710690a1ebd53eeccf3b198d304286126e
6 years, 3 months ago (2014-09-05 05:29:00 UTC) #17
Cait (Slow)
lgtm
6 years, 3 months ago (2014-09-05 20:15:35 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:37:17 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37fac505ffd432f088abbc5056e7c72ca59ff017
Cr-Commit-Position: refs/heads/master@{#293453}

Powered by Google App Engine
This is Rietveld 408576698