Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3006)

Unified Diff: chrome/browser/extensions/window_controller_list.cc

Issue 543873002: Add ChromeExtensionFunctionDetails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/window_controller_list.h ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/window_controller_list.cc
diff --git a/chrome/browser/extensions/window_controller_list.cc b/chrome/browser/extensions/window_controller_list.cc
index bfaefe1ce624e088464823fd3e5bc9bc9712ebb7..0eadbea36d529a82bfe7af7410a431b125e6a5b5 100644
--- a/chrome/browser/extensions/window_controller_list.cc
+++ b/chrome/browser/extensions/window_controller_list.cc
@@ -6,7 +6,7 @@
#include <algorithm>
-#include "chrome/browser/extensions/chrome_extension_function.h"
+#include "chrome/browser/extensions/chrome_extension_function_details.h"
#include "chrome/browser/extensions/window_controller_list_observer.h"
#include "components/sessions/session_id.h"
#include "ui/base/base_window.h"
@@ -62,21 +62,21 @@ WindowController* WindowControllerList::FindWindowById(int id) const {
}
WindowController* WindowControllerList::FindWindowForFunctionById(
- const ChromeUIThreadExtensionFunction* function,
+ const ChromeExtensionFunctionDetails& function_details,
int id) const {
WindowController* controller = FindWindowById(id);
- if (controller && function->CanOperateOnWindow(controller))
+ if (controller && function_details.CanOperateOnWindow(controller))
return controller;
return NULL;
}
WindowController* WindowControllerList::CurrentWindowForFunction(
- const ChromeUIThreadExtensionFunction* function) const {
+ const ChromeExtensionFunctionDetails& function_details) const {
WindowController* result = NULL;
// Returns either the focused window (if any), or the last window in the list.
for (ControllerList::const_iterator iter = windows().begin();
iter != windows().end(); ++iter) {
- if (function->CanOperateOnWindow(*iter)) {
+ if (function_details.CanOperateOnWindow(*iter)) {
result = *iter;
if (result->window()->IsActive())
break; // use focused window
« no previous file with comments | « chrome/browser/extensions/window_controller_list.h ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698