Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: chrome/browser/extensions/chrome_extension_function.h

Issue 543873002: Add ChromeExtensionFunctionDetails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_extension_function.h
diff --git a/chrome/browser/extensions/chrome_extension_function.h b/chrome/browser/extensions/chrome_extension_function.h
index dc35815cd818c11e721a38e904da40b1cf733521..98002b433cb686ec66b895eae728d255a64ca39d 100644
--- a/chrome/browser/extensions/chrome_extension_function.h
+++ b/chrome/browser/extensions/chrome_extension_function.h
@@ -20,6 +20,10 @@ class WindowController;
// A chrome specific analog to AsyncExtensionFunction. This has access to a
// chrome Profile.
+//
+// DEPRECATED: Please consider inherting UIThreadExtensionFunction directly.
+// Then if you need access to Chrome details, you can construct a
+// ChromeExtensionFunctionDetails object within your function implementation.
class ChromeUIThreadExtensionFunction : public UIThreadExtensionFunction {
public:
ChromeUIThreadExtensionFunction();
@@ -64,6 +68,11 @@ class ChromeUIThreadExtensionFunction : public UIThreadExtensionFunction {
// A chrome specific analog to AsyncExtensionFunction. This has access to a
// chrome Profile.
+//
+// DEPRECATED: Please consider inherting UIThreadExtensionFunction or
+// AsyncExtensionFunction directly. Then if you need access to Chrome details,
+// you can construct a ChromeExtensionFunctionDetails object within your
+// function implementation.
class ChromeAsyncExtensionFunction : public ChromeUIThreadExtensionFunction {
public:
ChromeAsyncExtensionFunction();
@@ -83,6 +92,11 @@ class ChromeAsyncExtensionFunction : public ChromeUIThreadExtensionFunction {
// A chrome specific analog to SyncExtensionFunction. This has access to a
// chrome Profile.
+//
+// DEPRECATED: Please consider inherting UIThreadExtensionFunction or
+// SyncExtensionFunction directly. Then if you need access to Chrome details,
+// you can construct a ChromeExtensionFunctionDetails object within your
+// function implementation.
class ChromeSyncExtensionFunction : public ChromeUIThreadExtensionFunction {
public:
ChromeSyncExtensionFunction();
« no previous file with comments | « chrome/browser/extensions/api/tabs/windows_util.cc ('k') | chrome/browser/extensions/chrome_extension_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698