Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 543853002: cc: Don't analyze masks for solid color. (Closed)

Created:
6 years, 3 months ago by vmpstr
Modified:
6 years, 3 months ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Don't analyze masks for solid color. We don't handle masks that are solid color. Also, I suspect that most masks aren't solid color, so we shouldn't waste time analyzing them. R=enne, danakj Committed: https://crrev.com/9c419a4f4834d8f799a0e1f7611314fc56ef6a4e Cr-Commit-Position: refs/heads/master@{#293606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
vmpstr
Maybe worth it? Maybe not? Please take a look.
6 years, 3 months ago (2014-09-04 20:54:17 UTC) #1
danakj
LGTM cuz if the mask doesn't have a texture, there's no mask at all.
6 years, 3 months ago (2014-09-04 20:58:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/543853002/1
6 years, 3 months ago (2014-09-05 17:42:22 UTC) #4
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-05 23:44:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/543853002/1
6 years, 3 months ago (2014-09-05 23:51:33 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 05:53:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/543853002/1
6 years, 3 months ago (2014-09-06 06:09:25 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as c5be262ae21834cf979fcd843b338345d5ed43b4
6 years, 3 months ago (2014-09-06 10:44:40 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:16 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c419a4f4834d8f799a0e1f7611314fc56ef6a4e
Cr-Commit-Position: refs/heads/master@{#293606}

Powered by Google App Engine
This is Rietveld 408576698