Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 543833002: Add method to GrProgramResource to record that pending a execution was completed. (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@progelem
Visibility:
Public.

Description

Add method to GrProgramResource to record that pending a execution was completed. BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/ac8d6193eaa29e02d1786fe56efa98eefee74e50

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -12 lines) Patch
M include/gpu/GrGpuResource.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/gpu/GrProgramElement.h View 1 1 chunk +1 line, -7 lines 0 comments Download
M include/gpu/GrProgramResource.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M src/gpu/GrProgramElement.cpp View 1 2 chunks +17 lines, -1 line 0 comments Download
M src/gpu/GrProgramResource.cpp View 1 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
Adds functionality that should have been in https://codereview.chromium.org/537773004/ This comes up when an effect is ...
6 years, 3 months ago (2014-09-04 20:07:04 UTC) #2
robertphillips
lgtm
6 years, 3 months ago (2014-09-04 20:11:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/543833002/1
6 years, 3 months ago (2014-09-04 20:14:06 UTC) #5
commit-bot: I haz the power
Failed to apply patch for include/gpu/GrProgramResource.h: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-09-04 20:14:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/543833002/20001
6 years, 3 months ago (2014-09-04 21:05:44 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-04 21:13:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as ac8d6193eaa29e02d1786fe56efa98eefee74e50

Powered by Google App Engine
This is Rietveld 408576698